Commit graph

75159 commits

Author SHA1 Message Date
Eric Kohl 78f13ae5ad [NETSHELL] Improvements to the network setup (1/x)
Step 1: Find the TcpIp transport and enumerate the installed network adapters using INetCfg.

Next Step: Find out how the binding process works and bind the TcpIp transport to all enumerated network adapters. This will replace the blind binding process we are using right now.
2019-06-17 01:18:05 +02:00
Eric Kohl 24b22db77e [NETCFGX] Resize a helper buffer to accommodate a device instance id.
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
2019-06-17 00:46:30 +02:00
Eric Kohl 76224b711b [MEDIA] Add netcfgx.dll to the EarlyRegisterDll list so that we can use it in the 2nd install phase. 2019-06-16 23:59:53 +02:00
Eric Kohl 9bf78b6a95 [NETCFGX] Set the ComponentId value when a NIC is installed. 2019-06-16 23:59:52 +02:00
Mark Jansen f3d1d38041
[INPUT] Don't race the system to free an imagelist 2019-06-16 23:11:03 +02:00
Benjamin Aerni 939b25a15a [I8042PRT] Add Latitude E6400 to the hack list (#1665)
Let it make grow, grow, grow... !!
2019-06-16 23:00:53 +02:00
Mark Jansen bcffdd0b16
[RASAPI32] Add RasClearConnectionStatistics stub
CORE-10092
2019-06-16 13:56:54 +02:00
Thomas Faber 00e882c2b1
[WIN32K:ENG] In PDEVOBJ_vRefreshModeList, find a proper match for the current display mode instead of assuming a constant index. CORE-15325 2019-06-16 12:45:58 +02:00
Hermès Bélusca-Maïto 28ed2347ef
[HOSTNAME] Retrieve the DNS *host name* of the computer, and not the computer name.
CORE-16095, ROSTESTS-326
2019-06-16 01:00:40 +02:00
Doug-Lyons 077a1b8dba
[ROSTESTS] Add a new test for "gethostname" in ws2_32_apitest. (#1630)
ROSTESTS-326

Make the test more robust; clean up on failures.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-06-16 00:15:55 +02:00
Mark Jansen 04712d418c
[WIN32K] Use KeStackAttachProcess 2019-06-15 21:26:41 +02:00
Mark Jansen 97d1590914
[WIN32K] Attach to the target process before unhooking
CORE-16083
2019-06-15 21:26:41 +02:00
Mark Jansen 7a3937ddaf
[WIN32K] Fix indenting in IntRemoveHook 2019-06-15 21:26:35 +02:00
Victor Perevertkin 1552434940 [NTFS] Do not print debug message for every function call by default 2019-06-15 19:24:27 +03:00
Hermès Bélusca-Maïto 16646fb19c
[MAGNIFY] Minor whitespace / formatting fixes; use the new file headers + some code simplifications here and there... 2019-06-15 19:11:21 +02:00
Hermès Bélusca-Maïto 4e91b6d5db
[MAGNIFY] Minor fixes for zoom handling.
- Zoom factor is unsigned.
- It is comprised between 1 and 9, other values are invalid.
- Check for value validity when reading the zoom string from the combo-list.
2019-06-15 18:33:28 +02:00
Bișoc George 9ade0e7b04
[MAGNIFY] Fix a string buffer misuage that led to division by zero exception. (#1655)
The iZoom variable was wrongly initialized to zero because the _ttoi()
called failed due to the fact the temporary string buffer was too small.
2019-06-15 18:12:54 +02:00
Serge Gautherie b13990bd78
[SETUPAPI] Revert "Fix a typo in CM_Query_Resource_Conflict_List." (#1634)
Previous code was correct.
This reverts commit c47ad98f.
2019-06-15 17:55:33 +02:00
Baruch Rutman 22064d7787
[LPK] Fix for CORE-16115. (#1654)
Proposed changes:

- Use the total extent (width) and font metrics (height) as values
  to put in the lpSize variable instead of calling ScriptString_pSize()
  in the LpkGetTextExtentExPoint() function.

- Use GetTextExtentExPointWPri in more cases as another effort to get the data.

- Trailing whitespace fixes.
2019-06-15 17:37:51 +02:00
Baruch Rutman 1a7ffd29d6
[LPK] Update Wine BiDi code. (#1651)
Imports the changes from
ef07087f47
2019-06-15 17:24:38 +02:00
Joachim Henze 10f00f8c1c [MSI] Fix regression CORE-14646
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.

The regression was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445

Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.

I also committed the same fix to 0.4.12-RC-32-g152ee20.
2019-06-14 23:21:37 +02:00
Yaroslav Kibysh ec14975612 [MSTSC] Center window at start 2019-06-14 19:12:40 +03:00
Eric Kohl 7b29f4d975 [NETCFGX] InstallNetDevice: Run the default device installer before making class-specific changes. 2019-06-13 14:16:25 +02:00
Eric Kohl cd579382b5 [IPCONFIG] Indentation and coding style fixes. No code changes! 2019-06-13 02:35:53 +02:00
Giannis Adamopoulos cc25a266f2 [COMCTL32] imagelist: Make the exported functions use the internal IImageList2
- Add a hack to rename the exported functions and use the Internal_ prefix for them so that the IImageList can use them with minimal code changes.
- Add the correct implementation of the affected exported functions making them now use the IImageList of the passed HIMAGELIST.

This indirection is possible because an HIMAGELIST is also a IImageList*.
This indirection is also needed because we can end up using image lists created by either comctl32 v5 or comctl32 v6.
This is how windows manage to use an HIMAGELIST created by comctl32 v5 when it is passed to comctl32 v6.
What really happens in this scenario is that the exported functions of both versions end up using the interface
stored in the object without checking if this interface is the version provided in the same dll or in the other.
2019-06-12 19:20:44 +03:00
Eric Kohl 419fb423ce [IPCONFIG] Show the Description and Physical Address for disconnected network adapters. 2019-06-12 18:04:50 +02:00
Eric Kohl 6734d4ca09 [IPCONFIG] Fix crash on 'ipconfig /all'
Ipconfig should not display invalid 'Lease Obtained' and  'Lease Expires' times because it did not yet receive any DHCP configuration.

Fixes CORE-11837
2019-06-12 17:48:35 +02:00
Eric Kohl 6866c0aede [NTOSKRNL][USETUP][UMPNPMGR] Pass user response data to NtPlugPlayControl(PlugPlayControlUserResponse).
- Windows requires 16 bytes of response data.
- Add the PLUGPLAY_CONTROL_USER_RESPONSE_DATA type.
- Usetup and Umpnpmgr must fail if NtPlugPlayControl(PlugPlayControlUserResponse) does not return STATUS_SUCCESS.
2019-06-12 13:48:27 +02:00
Yaroslav Kibysh 0e1e12b619
[SHORTCUTS] Update Ukrainian shortcuts. (#1639) 2019-06-11 23:23:46 +02:00
Yaroslav Kibysh 5d88df8c35
[ROSAPPS] Update Ukranian shortcuts. (#1638) 2019-06-11 23:01:44 +02:00
Hermès Bélusca-Maïto 9060b0cb7a
Fix build (forgot a comma ;) 2019-06-11 22:36:10 +02:00
Hermès Bélusca-Maïto 41e7c818d1
[NTOS] IoSetHardErrorOrVerifyDevice(): Check whether the IRP is not associated with any thread. 2019-06-11 22:29:34 +02:00
Pierre Schweitzer f6eb13a969
[NTOSKRNL] Rework ObpDeleteSymbolicLinkName and ObpCreateSymbolicLinkName
So that they handle LUID mappings and process device maps.

Get rid of the ObpParseSymbolicLinkToIoDeviceObject helper and introduce a
new helper ObpProcessDosDeviceSymbolicLink that will do the same things
but also handle name creation/deletion as well as device map handling.
All this is based on previous code (hence the same comments :-)).

What's left to do now is to add support for device maps in ObpLookupObjectName
2019-06-11 21:21:52 +02:00
Eric Kohl acc821e1ea [UMPNPMGR] PNP_SetHwProf is not implemented in Windows XP and returns CR_CALL_NOT_IMPLEMENTED. 2019-06-11 16:32:44 +02:00
Pierre Schweitzer 95848cb538
[BTRFS] Fix MSVC build
CORE-16111
2019-06-11 12:50:49 +02:00
Pierre Schweitzer 92543df9e1
[BTRFS] Fix MSVC build
CORE-16111
2019-06-11 12:43:43 +02:00
Pierre Schweitzer f381137c89
[BTRFS] Upgrade to 1.3
CORE-16111
2019-06-11 12:35:19 +02:00
Eric Kohl 90aa2c26f8 [NETCFGX] Improvements to the TCP/IP settings dialog.
- Separate the gateway settings from the DHCP settings.
- Enable Edit and Delete buttons only if an item in a list box has been selected.

CORE-9908
2019-06-11 06:58:42 +02:00
Victor Perevertkin da1b08e842 [USBSTOR] Properly handle IRP_MN_QUERY_DEVICE_RELATIONS(BusRelations) for FDO.
This fixes Driver Verifier warnings
2019-06-11 04:39:43 +03:00
Victor Perevertkin 04409942d6 [USBSTOR] Register dumb IRP_MJ_SYSTEM_CONTROL handler.
This satisfies Driver Verifier
2019-06-11 04:39:43 +03:00
Victor Perevertkin 126abaf88f [USBSTOR] Improve handling of IRP_MN_QUERY_DEVICE_TEXT for PDOs
CORE-15883
2019-06-11 04:39:43 +03:00
Victor Perevertkin 40b25634ff [USBSTOR] Do not leak fields of DeviceExtensions upon device removal 2019-06-11 04:39:43 +03:00
Victor Perevertkin fa530aee92 [DISK] Disable IsFloppyDevice check.
It wrongly marks USB flash drives as a floppy device
2019-06-11 04:39:43 +03:00
Victor Perevertkin b7de5870e6 [USBSTOR] Weaken the type checks of a device.
This adds usb-cdrom support to usbstor.sys
2019-06-11 04:39:43 +03:00
Victor Perevertkin 7bb93db372 [USBSTOR] Refactor device reset and pipe reset code.
Return correct status codes from completion routines.
Reject requests while the device is being reset
2019-06-11 04:39:43 +03:00
Victor Perevertkin aaa90f6986 [USBSTOR] Do not try to retry a failed request
for all cases except receiving a USBD_STATUS_STALL_PID status.
This decision should be made by higher-level driver (and classpnp drivers do it)
2019-06-11 04:39:43 +03:00
Victor Perevertkin c7ed299aaa [USBSTOR] Issue a SCSI Request Sense after receiving
a CSW with failed status. CORE-15884
Based on Vadim Galyant's patches to usbstor
2019-06-11 04:39:43 +03:00
Victor Perevertkin 5046f1b3fa [USBSTOR] Keep CBW and CSW inside an IRP context.
Remove obsolete fields from the IRP context structure.
2019-06-11 04:39:43 +03:00
Victor Perevertkin c452f7dab4 [USBSTOR] Refactor request issue code.
Pipe handle selection now made more correctly.
Simplified an MDL allocation for a request.
2019-06-11 04:39:43 +03:00
Victor Perevertkin 84f78cb0d7 [USBSTOR] Better handle CBW/CSW transfer errors
and set SrbStatus correctly.
2019-06-11 04:39:43 +03:00