Commit graph

76058 commits

Author SHA1 Message Date
Joachim Henze baa9a3e611 [0.4.13][APISETS][KERNEL32] Appease regression CORE-16563
Symptom "Far Manager 3.0 Build 5200 can not load NetBox.dll"
due to uncaught exception when accessing GetSystemTimePreciseAsFileTime().

The symptom started to show with 0.4.13-dev-986-g
029b8f2cf9
as LDR exposes more Vista+ stuff since then.

The fix is a selective backmerge of master PR-1963
2019-12-25 16:24:55 +01:00
Joachim Henze a596f5c8bd [0.4.13][APISETS] Appease regression CORE-16563 for another function (2 of 2)
Symptom: "Far Manager main app unhandled exception when exiting"

The issue started to show with 0.4.13-dev-986-g
029b8f2cf9

Thanks to Mark Jansen for providing this 2nd patch.

cherry picked from commit 0.4.14-dev-654-g
6f93f2cf10
2019-12-23 15:17:25 +01:00
Joachim Henze 57cd41a6c7 [0.4.13][APISETS] Appease regression CORE-16563 (1 of 2)
Symptom: "Far Manager main app does not longer start up"

The issue started to show with 0.4.13-dev-986-g
029b8f2cf9

Thanks to Mark Jansen for providing this first patch.

cherry picked from commit 0.4.14-dev-653-g
cabf120833
2019-12-23 15:16:43 +01:00
Joachim Henze 928625ccfa [0.4.13][NTOSKRNL] Workaround CORE-16387 & CORE-16449
Both most likely was introduced by activating feature
MiWriteProtectSystemImage() once.
Imho this feature is not stable yet, therefore I disable
it for releases.
Confirmation of reporters will have to be collected after
the commit.

Both problems most likely got visible by 0.4.12-dev-386-g
65dbfc2868

Master remains affected for now.
If no fix will appear during 0.4.14-dev'ing, then I will
commit this to master as well in 3months.
2019-12-17 00:06:05 +01:00
Joachim Henze aa2b39c872 [0.4.13][WIN32SS] Fix Opaque Text Fade while in Desktop Startup
This fixes CORE-16498, which got considerably more severe by
0.4.13-dev-209-g
dc7f4f682f

Thanks to the patches author Jim Tabor.
I merged manually analog 0.4.14-dev-594-g
5214a38fd0
2019-12-10 00:04:19 +01:00
Hermès Bélusca-Maïto 056aed0216 [ß.4.13][WINLOGON] Start the screensaver on the user desktop CORE-16548
since support for secure screensaver desktop is not
completely implemented in Winlogon.

This fixes a regression introduced between
0.4.10-dev-579-gc697f19 and 0.4.10-dev-582-g3270979

fix cherry picked from commit 0.4.14-dev-581-g
40db385716
2019-12-08 10:47:28 +01:00
Joachim Henze 777aff5b36 [0.4.13][FREELDR] Workaround regression CORE-16469
This prevents ReactOS asserting when 'My computer'
is opened, while it tries to send commands to floppy drive.

Many thanks to patches author Doug Lyons.

The regression was introduced by 0.4.13-dev-1081-g
eeff926ede

patch was not committed to master yet,
hbelusca continues investigation
2019-12-07 01:19:47 +01:00
Katayama Hirofumi MZ 3a1c14f9ba [0.4.13][NTOSKRNL][INBV] Fix IDB_SHUTDOWN_MSG position CORE-16342
Make "shutdown.bmp" (IDB_SHUTDOWN_MSG: 213x11px) horizontally centered.

This fixes a regression of 0.4.13-dev-961-g
238ea69ca0

Fix cherry picked from commit 0.4.14-dev-546-g
55aed4f8fa
2019-12-02 23:42:51 +01:00
Joachim Henze 2314b107e4 [0.4.13][NTOSKRNL] Restore section layout to fix BSOD regression CORE-14683
This version (after .rsrc) works different than the
proper version I used for 0.4.12 (after .reloc).

Inserting after .rsrc as actually not correct, but Thomas believes it can
be used as a temporary trick to avoid random memory corruption upon
relocations of the kernel, caused by ROSBE-154.

I follow his advice, although when judging from practical tests only:
as long as we limit this script to NTOSKRNL like I do for releases
there have no negative consequences been observed in real life yet
even with the proper version of 0.4.12.
Up to now those problems have only been observed when used for drivers
MODULE TYPE sdk/cmake/gcc.cmake as well, like
it was tried for a moment in master 0.4.13-dev-609-g
c4d8e2a6e9

Using for drivers immediately did lead to BSODs like CORE-16183 and therefore was
mitigated in master by total disabling of the scripts for both,
kernel and drivers in
0.4.13-dev-621-g
36e9a6f8dd

To allow installing DVDWritenow without BSOD,
we need the script at least for ntoskrnl!

Master remains affected by the BSOD until Thomas allows to commit there as well.
2019-11-30 14:10:17 +01:00
Mark Jansen 7896d3d4ec [0.4.13][URLMON] Delay-load advpack
I doubt it helps for CORE-5007 (as it was stated in master),
that ticket most likely got fixed beforehand already.

But I already tested: Delay-loading fixes CORE-15795,
which was unhidden by 0.4.12-dev-632-g
d93e516747

The fix by delay loading was cherry picked from commit
0.4.14-dev-475-g
82b758974f

It's not just a workaround, Windows delay-loads like that as well.
Thomas believes this specific delay-load will not trigger
the LD bug CORE-6504 within our gcc toolchain.

Thanks for help of Mark Jansen, Thomas Faber and Fabian Maurer.
2019-11-30 00:55:08 +01:00
Joachim Henze ec663c87f0 [0.4.13][COMCTL32] Fix listview scrollbars flashing CORE-16466
Many Thanks to patches author JIRA user 'I_Kill_Bugs',
but also to Doug Lyons and Fabian Maurer.

Unhidden by SVN r75735 == git 0.4.7-dev-168-g
6af37fd54e

cherry-picked from 0.4.14-dev-312-g
b931f643e3
2019-11-13 00:59:13 +01:00
Joachim Henze c8edd36e3e [0.4.13] Revert "[MEDIA][FONTS] Add Microsoft Sans Serif font (#1805)"
To fix regression CORE-16497 "Chromium BSU setup using wrong font"

It is a good idea to add micross.ttf, but we should not use
"Liberation Sans" as template but instead either create it from scratch
or at least use something with the same metrics as the MS font.

Maybe "Tahoma" would have been a better starting point?
In Windows 2k3sp2 "Tahoma" and "MS Sans Serif" are not the same binary,
but they look almost identical to the human eye.

This reverts commit 0.4.13-dev-796-g
eefc544202
2019-11-10 21:59:38 +01:00
Joachim Henze 121db03936 [0.4.13] Revert 3 [NTOS:KE] commits to avoid regression CORE-16448
Symptom: stacklog via 'bt' command in gcc+kdbg regressed in certain cases.

This reverts the guilty commit 0.4.13-dev-514-g
3c8f19eb21.

But also reverts 2 tightly related follow-up commits
0.4.13-dev-515-g
04906f2abb
and
0.4.13-dev-516-g
4d5a2dd0f3

We revert only in RC, but master remains affected for now,
the developers aim to fix master by WIP PR#2003 later.

I considered following the bleeding-edge-development being
too risky here. Many unrelated changes in master since then.
2019-11-03 17:36:40 +01:00
Katayama Hirofumi MZ 9a845598dc [0.4.13][WIN32SS][NTUSER][USER32] Fix menu checkmarks (#2009)
This will fix regression CORE-16470
"Black squares in menubar of Abiword 2.6.8"

This is a partial revert of the guilty rev 0.4.13-dev-702-g
1e91a1690d
- Don't change background mode.

And is an addendum to CORE-13211.

test results LGTM:
https://reactos.org/testman/compare.php?ids=69593,69596 VBox
https://reactos.org/testman/compare.php?ids=69594,69597 KVM

fix cherry picked from commit 0.4.14-dev-186-g
b3033b81a4
2019-11-01 02:12:03 +01:00
Katayama Hirofumi MZ c35c7f2c80 [0.4.13][NOTEPAD] Prioritize ASCII over UTF-8 (#2006)
To fix regression CORE-16467 which was caused
by adding encoding-heuristic in 0.4.13-dev-927-g
e85664a3d8

fix cherry picked from commit 0.4.14-dev-184-g
142d16c8a0
2019-10-31 21:24:09 +01:00
Timo Kreuzer 09d3029dd8 [NTOS] Fix a regression in the PE loader CORE-11717
which caused images to be loaded up to MmHighestUserAddress,
thus overwriting the shared user page.

This is now fixed by using MM_HIGHEST_VAD_ADDRESS as the margin instead.
This commit allows again to load WIN32K.sys of Win2K3SP2
which regressed by SVN 67793 == git
3565260212

cherry picked from commit 0.4.14-dev-143-g
56da95671c
2019-10-27 02:19:51 +02:00
Joachim Henze c13224e68c [0.4.13][WIN32SS] Fix last user visible parts of regression CORE-10855
When Themesvc was disabled, some Window titlebar
frames were drawn too thin until the window
was actively resized in y by the user.

That and similar symptoms started to show up after SVN r68904 ==
6dfa71c487

Many thanks to patches author Doug Lyons.

We leave the ticket unresolved still due to explicit request of
James Tabor, who wants to continue working in that context.

cherry picked from commit 0.4.14-dev-121-g
9e14a762d5
2019-10-25 00:45:44 +02:00
Joachim Henze 5e4310bcc9 [0.4.13][WINED3D] Workaround regression CORE-15408
Many 3D applications crashed with 'WineD3D fake window' msgbox
if they were used in VirtualBox with graphics driver
'VBoxDisp.sys from VM guest additions + installed 3D acceleration'

That was a regression of SVN r75847 == git
3d13ed394e

Contrary we had no such issues with the SW emulation.
The reason for the bug is that
VBoxDisp only supports OpenGL 2.1 (GLSL 120) and WineD3D
tried to use shaders for OpenGL 3.2 (GLSL 150).

This workaround disables the usage in a hard-coded way for
all graphics adapters. Should be ok for now, as ros does not
really support any modern GPU drivers yet.
Proper working runtime detection would be better ofc.

Thx to Doug Lyons & Fabian Maurer

cherry picked from commit 0.4.14-dev-113-g
082f230ac7
2019-10-22 03:13:35 +02:00
Joachim Henze e5018461c1 [0.4.13][COMCTL32] Address regression CORE-14622
"Avira Antivir Personal 6.35.00.243" had issues painting its
setup wizard dialog with correct background color.
That part was a regression of SVN r74136 == git
b1b42795a9

and also did not draw its umbrella bmp, which did never work
in ros up to now afaik.

https://reactos.org/testman/compare.php?ids=69394,69478 VBOX
https://reactos.org/testman/compare.php?ids=69395,69479 KVM

Thanks to patches author Doug Lyons and HBelusca.

Wine has been reported to be affected by that bug as well:
https://bugs.winehq.org/show_bug.cgi?id=46636
Not sure whether our patch will be accepted by Wine,
to my naive eye this looks like an interim solution.

cherry picked from commit 0.4.14-dev-107-g
f2f833c53c
2019-10-22 01:48:57 +02:00
Hervé Poussineau fa70635521 [0.4.13] Revert "[NTOS:KDBG] Use CONTEXT instead of KTRAP_FRAME" CORE-16231
This reverts guilty commit 0.4.13-dev-254-g
e5bffe49da.

To repair step/next commands in GCC Kernel Debugger

https://reactos.org/testman/compare.php?ids=69388,69392 VBox on master
https://reactos.org/testman/compare.php?ids=69389,69393 KVM on master

cherry picked from commit 0.4.14-dev-56-g
7390376753
2019-10-19 00:55:31 +02:00
Joachim Henze 45dbb08422 [0.4.13] Revert "[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF"
To avoid CORE-15804 MSTSC fails to connect with error "ERROR: Bad packet header"

This reverts commit 0.4.12-dev-752-g
6bc61f63f1.

like last release
2019-10-15 01:49:07 +02:00
Joachim Henze c722bc867e [0.4.13][BTRFS] Create system threads with OBJ_KERNEL_HANDLE
CORE-16375 #1914

Thanks to patches author ThFabba.
According to JIRA user 'Zero3k' this allows to format a
BTRFS drive again without INVALID_KERNEL_HANDLE BSOD.

Master remains affected,
our devs wait for upstream integration
2019-10-13 22:11:43 +02:00
Joachim Henze e2e90230d1 [0.4.13][BROWSEUI][SHELLFIND] Allow to 'Open Containing Folder' CORE-16391
of a search result again.

The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b

I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.

Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.

cherry picked from commit 0.4.14-dev-39-g
cd2a274ef7
2019-10-12 16:50:56 +02:00
Doug Lyons 44202f0749 [0.4.13][BROWSEUI][SHELLFIND] Make Search Item general and Show Sub-directories (#1927)
Shell Find Improvement to make Search Item general by adding asterisks
before and after before search and show sub-directories in find listing. CORE-16152

cherry picked from commit 0.4.14-dev-9-g
b6b7bda443
2019-10-12 16:48:55 +02:00
Joachim Henze 609f2aeeb7 [0.4.13][WIN32SS] Fix regression CORE-16306 PR-1943
Symptom:
The menu popup position for language selection in UltraIso regressed

It regressed by 0.4.13-dev-791-g
a59df3858c

Many thanks to the author Mark Jansen.

The fix has not been committed to master yet, but I hope
the PR will be merged during the next days as well.
2019-10-12 03:35:47 +02:00
Joachim Henze 0a03b36aee [0.4.13][WIN32SS] Fix regression CORE-16393
Symptom "cmd did not hide the taskbar anymore when switching to fullscreen"

It regressed by SVN r75407 == git
09ab5ea7ed

VBox LGTM https://reactos.org/testman/compare.php?ids=69295,69297
 KVM LGTM https://reactos.org/testman/compare.php?ids=69296,69298

Many thanks to the patches author James Tabor.

cherry picked from commit 0.4.14-dev-38-g
96ef605f4b
2019-10-11 23:26:27 +02:00
Brock Mammen 1e50a4e7d3 [0.4.13][EXPLORER] Fix right-click menu for taskbar clock CORE-16397 (#1944)
It was a regression introduced by 0.4.12-dev-943-e
7ad10241f12bb3760d6cdb73fd7077f87ce1cd3

The fix was cherry-picked from 0.4.14-dev-33-g
3fee5d0e1c
2019-10-09 01:22:46 +02:00
Joachim Henze 11178f38e4 [0.4.13][UNIATA] Workaround regression CORE-16078, booting broke on specific Intel Z170
JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b546130731

For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen".
We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was just committed into the RC, master remains affected.

cherry picked from previous release
commit a57363f363
2019-10-08 23:33:32 +02:00
Katayama Hirofumi MZ a88827e1bc [0.4.13][MEDIA][FONTS] Replace 'Verdana' fonts CORE-16400 (#1948)
In order to avoid a regression with Cyrillic text in Inno Setup 5.6.1
and Magma visual style
The regression was introduced by 0.4.13-dev-1009-g
ca967db5ca

- Replace "Verdana", "Verdana Bold", "Verdana Bold Italic" and
 "Verdana Italic" fonts by duplicating "DejaVu Sans" fonts and renaming them.
- Replace LICENSE file.

I made these font files by using FontForge. Their family name is "Verdana".
Their display names are "Verdana", "Verdana Bold", "Verdana Bold Italic"
and "Verdana Italic". Their font filenames are verdana.ttf, verdanab.ttf,
verdanaz.ttf and verdanai.ttf.
The Underline Positions are hacked by adding
an integer value for workaround of FontForge's bug.
cherry picked from commit 0.4.14-dev-6-g
f45dd65773
2019-10-08 21:51:40 +02:00
Joachim Henze 67211fa366 [0.4.13][COMCTL32] Appease regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).

Thanks to patches author Doug Lyons.

The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.

Like in last releases.
2019-10-04 20:27:14 +02:00
Joachim Henze 9c5319b69f [0.4.13][RDBSS] Avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.

like in last release
(cherry picked from commit 26080d0c64)
2019-10-03 22:50:10 +02:00
Pierre Schweitzer 03aa4a6467 [0.4.13][FREELDR] Stop asking people to report bugs on ros-dev@reactos.org
cherry picked from commit 0.4.14-dev-5-g
17db4217a8
2019-10-03 22:24:45 +02:00
Joachim Henze d27a20233d [0.4.13][D3DCOMPILER_43] Addendum to last commit CORE-14955 & CORE-15652
GCC Linux build had no issues with the last commit in D3DCOMPILER_43 but
MSVC x86 & x64 v18.0.31101.0 choked on it with
error C4133: 'function' : incompatible types - from 'D3D_PRIMITIVE *' to 'DWORD *'
and similar.

MSVC v18.0.31101.0, target x86 and x64, flagged C4133 as error
MSVC v16.0.40219.1, target x86, flagged C4133 as warning

cherry picked from commit 0.4.14-dev-8-g
36d9e80add
2019-10-03 21:45:38 +02:00
Joachim Henze 9f1e2cd172 [0.4.13] Addendum to last commits documentation 2019-10-03 17:19:36 +02:00
Joachim Henze 67dd70e5ef [0.4.13] Avoid regressions CORE-14955 "Ddraw fullscreen crashes", CORE-15652
This brings us back to before guilty commit 0.4.10-dev-55-g
7af3969e9f

and therefore downgrades
dll/directx/wine/
D3D8,D3D9,DDRAW,D3DCOMPILER_43
to WineStaging 3.3 for this rls.
Also downgrades related header sdk/include/reactos/wine/wined3d.h
and for the first time also media/doc/README.WINE

Same versions of these dlls we had in every ros rls since 0.4.10rls.

Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
 DxDiag crashed when switching to fullscreen (CORE-14955),
 Diablo II crashed immediately (CORE-15652),
 Monster-Truck-Madness 2 demo crashed after main menu

Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.

This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with current Wine.

analog to 0.4.10-RC-17-g
bb4c55d650
2019-10-02 01:27:03 +02:00
Thomas Faber bff758f3da [0.4.13][WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
my testcase: this allows opening an exe/dll with MsDepends (CORE-12052)
Unfortunately still necessary, luckily still effective
and also reliably hides a lot of other crashes due to uncaught exceptions

like in last releases
cherry picked from commit bca25b10b4
2019-10-01 21:11:49 +02:00
Joachim Henze 07ad6e87e7 [0.4.13] Branch releases/0.4.13 & change KERNEL_VERSION_BUILD_TYPE "RC" 2019-09-30 18:13:25 +02:00
Serge Gautherie e413df4f4e [NTOS:MM] i386: Fix '_MI_NO_EXECUTE' typo
Addendum to 65dbfc2868.
2019-09-30 10:46:58 +03:00
Pierre Schweitzer 3f63f236ba
[SDK] Make our MEMORY_SECTION_NAME definitions consistent.
I choose the definition which is also used by Wine & Chromium.

CORE-12043
2019-09-29 14:18:11 +02:00
Pierre Schweitzer 3b78ca210e
[NTOSKRNL] Simplify buffer definition in MiQueryMemorySectionName().
Also take into account the UNICODE_STRING structure while computing whole size
This is based on Thomas' patch.

CORE-12043
2019-09-29 14:16:44 +02:00
Pierre Schweitzer ad547c960f
[NTDLL_WINETESTS] Section name query test is broken on W2K3 and will lead to a crash
Comment out the test for now and add a more "appropriate" test code for now
2019-09-29 14:13:55 +02:00
Thomas Faber a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
Fixes one of many crashes in shell32_winetest:shlfolder.
2019-09-29 12:42:26 +02:00
Serge Gautherie ed9f0dca14 [USBPORT] USBPORT_InvalidateEndpointHandler(): Properly enumerate endpoints 2019-09-29 13:39:12 +03:00
Victor Perevertkin 220bc820eb [FREELDR] Optimize and refactor the FAT driver.
Do not read the whole cluster chain for file on opening.
This removes restriction for opening files which span
within a large amount of clusters (>65k). That happened because
FrLdrTempAlloc cannot allocate more than about 256 KiB of memory.

Adjacent clusters for file are now read using one disk driver call.
2019-09-29 13:24:31 +03:00
Victor Perevertkin 195dc30484 [FREELDR] Add FAT caching to FAT filesystem driver.
This significantly increases the reading speed
2019-09-29 13:24:31 +03:00
Thomas Faber be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:39 +02:00
Thomas Faber b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:02 +02:00
Thomas Faber 6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385
Addendum to c2b476bd77.
2019-09-29 12:07:43 +02:00
Hermès Bélusca-Maïto e995147a1c
[HAL] Update the PCI hardware IDs database.
Extracted from the pci.ids database at https://pci-ids.ucw.cz/ from 2019-09-28 03:15:02 .
Maintained by Albert Pool, Martin Mares, Michal Vaner, and other volunteers from the PCI ID Project.
2019-09-28 18:52:59 +02:00
Stanislav Motylkov 07706eca3a [HAL] Fix more bugs in HalpDebugPciDumpBus (#1939)
- Don't match device id outside current vendor id list.
- Don't match subsystem id outside current device id list.
- Refactor some magic constants.

Addendum to 894635b.
2019-09-28 18:30:56 +02:00