Commit graph

86419 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto
4aee0280f9
[SETUPLIB][REACTOS][USETUP] Finish unification of MBR extended and primary/logical partitions
Fixes previous attempt at commit 0ca4e6dcf, which was reverted by commit
bbdcc14b1 because the partitioning checks mistook unpartitioned disks as
GPT.

Addendum to commit 99f0937fd.

The partition-creation checks are unified for these partitions into one
single function. To prepare for GPT support, the specifics are put into
a separate MBRPartitionCreateChecks() helper, called for MBR disks by the
upper-level function. GPT disks will have a similar helper in the future.
2024-11-24 18:13:17 +01:00
Thamatip Chitpong
69bf140506
[NTOS:MM][NTOS:CC] Rewrite some cache memory management functions (#7510)
Use section object pointer with byte offset instead of using base address. This simplifies the Mm functions themselves and also the code in Cc that calls them.
Also add minor fixes for MmFlushSegment and MmPurgeSegment.
2024-11-24 21:37:27 +07:00
Timo Kreuzer
541cb0d9b2 [USER32] ordinals -> @ 2024-11-24 13:40:11 +02:00
Stanislav Motylkov
bbdcc14b1c [REACTOS] Temporarily revert 0ca4e6dcfa, as requested by Hermès
The setup mistakes the unpartitioned disk as GPT.
This reverts commit 0ca4e6dcfa.
2024-11-23 23:12:02 +01:00
Hermès Bélusca-Maïto
0ca4e6dcfa
[SETUPLIB][REACTOS][USETUP] Finish unification of MBR extended and primary/logical partitions
Addendum to commmit 99f0937fd.

The partition-creation checks are unified for these partitions into one
single function. To prepare for GPT support, the specifics are put into
a separate MBRPartitionCreateChecks() helper, called for MBR disks by the
upper-level function. GPT disks will have a similar helper in the future.
2024-11-23 21:41:32 +01:00
Whindmar Saksit
89a3b8fa8a
[SHELL32] Refresh SHELLSTATE before writing it (#7516) 2024-11-22 20:33:12 +01:00
Stanislav Motylkov
096a5518e5 [GITHUB] Fix MSVC ARM build
The latest GitHub Actions runner image 20241113.3.0 uses WDK 10.0.26100.0,
which dropped support for 32-bit ARM platform:
- https://github.com/golang/go/issues/68552#issuecomment-2290064500
- https://github.com/actions/runner-images/issues/10981

Fix the failing build by sticking to WDK 10.0.22621.0.

CORE-17604
2024-11-22 00:14:10 +01:00
Hermès Bélusca-Maïto
edb6d19aa8
[NTOS:KD64] Only use the UNIMPLEMENTED macro in the debugger's KdpSys* helpers.
This basically avoids re-entering the debugger (via the embedded breakpoint)
while we are already running within its context.

In addition, this allows the tests for Kd/NtSystemDebugControl
(see PRs #7424 and #7426) to run without having ReactOS to crash.
2024-11-21 22:34:37 +01:00
Hervé Poussineau
2d3f3a1613 [COMPBATT] Use BATTERY_TAG_INVALID instead 0 when applicable 2024-11-20 21:47:13 +01:00
Hervé Poussineau
05ae94092e [COMPBATT] Free device-related memory only if we failed
Otherwise, we just inserted in the BatteryList this device, and we will
probably crash later when accessing it.
2024-11-20 21:47:13 +01:00
Hervé Poussineau
2323dbcb4f [COMPBATT] Keep incoming Status on unknown IOCTL 2024-11-20 21:47:13 +01:00
Oleg Dubinskiy
f9e430f65b
[NTOS:FSRTL] FsRtlAcquireFileExclusiveCommon: don't return before acquiring a file resource, except special cases (#7273)
* Don't return before file object's resource is acquired in FsRtlAcquireFileExclusiveCommon, except some special return cases, when return is reuired. Based on hpoussin_filter_extra.patch by Herve Poussineau (hpoussin) with improved comment, which matches the actual behaviour now.
This is required by fltmgr.sys driver from Windows XP/Server 2003 to work correctly, so this change fixes asserts/exceptions when releasing the file via FsRtlReleaseFile after acquiring, when using 3rd party filter drivers from several antivirus programs (e. g., Avast Free Antivirus all versions, AVG Antivirus Free 18.8, Avira AntiVir Personal 8.2, Dr. Web Security Space 8.0, Kaspersky Antivirus 2012 etc. etc.).
CORE-14157, CORE-14635, CORE-19318

* Add braces around return

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>

* Improve the comment (make it more detailed)

* Correct checks sequence

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2024-11-20 09:52:38 -06:00
Oleg Dubinskiy
8ed8682256
[NTOS:FSRTL] FsRtlAcquireFileExclusiveCommon: don't return before acquiring a file resource, except special cases (#7273)
Don't return before file object's resource is acquired in FsRtlAcquireFileExclusiveCommon, except some special return cases, when return is required. Based on hpoussin_filter_extra.patch by Herve Poussineau (@hpoussin) with improved comment, which matches the actual behaviour now.
This is required by fltmgr.sys driver from Windows XP/Server 2003 to work correctly, so this change fixes asserts/exceptions when releasing the file via FsRtlReleaseFile after acquiring, when using 3rd party filter drivers from several antivirus programs (e. g., Avast Free Antivirus all versions, AVG Antivirus Free 18.8, Avira AntiVir Personal 8.2, Dr. Web Security Space 8.0, Kaspersky Antivirus 2012 etc. etc.).
CORE-14157, CORE-14635, CORE-19318
2024-11-20 16:47:32 +01:00
Whindmar Saksit
4d0a26db58
[SHLWAPI][SHLWAPI_APITEST] Optimize StrRetToStrW WSTR handling (#7513)
This avoids Alloc/Free while also matching the Windows behavior.
2024-11-19 23:50:08 +01:00
Timo Kreuzer
e3c859ed96 [PSDK] intsafe.h: Define MIN/MAX macros the same way as in stdint.h
This avoids redefinition warnings.
2024-11-19 17:06:21 +02:00
Thamatip Chitpong
d52031a4f1
[NTOS:MM] MmPurgeSegment: Fix missing MmDereferenceSegment cleanup (#7509)
MiGrabDataSection adds a refcount. There is a missing MmDereferenceSegment cleanup in case of range check error.
Fix that by moving MiGrabDataSection calling code to after range check.
2024-11-19 11:17:41 +07:00
Vitaly Orekhov
2e3a080e10
[PSDK] Add definitions for WLAN_AVAILABLE_NETWORK.dwFlags member (#7504)
Enable use of flags denoting state of Wi-Fi access point relative to the network adapter trying to connect to it. Used when working with WLAN_AVAILABLE_NETWORK.dwFlags to check whether we are connected to the network or not, for instance.

These flags have been introduced in Windows 10.

References:
- https://learn.microsoft.com/en-us/windows/win32/api/wlanapi/ns-wlanapi-wlan_available_network
- Windows SDK

CORE-6905
2024-11-18 21:31:17 +01:00
Vincent Franchomme
1f2d67a841
[FS_REC] Rename Ext2 recognizer to Ext recognizer (#7497)
Rename the Ext2 recognizer to a more generic Ext to be more future-proof with a possible upcoming ext4 support.
Also, it already makes no sense to use the name ext2 as it already recognizes all the FS of the "Ext family".

In addition, add the Ext Recognizer for CDs.
2024-11-18 21:27:16 +01:00
Václav Zouzalík
8f0337f217
[TIMEDATE] Update German (de-DE) translation (#7490) 2024-11-18 21:26:13 +01:00
Václav Zouzalík
531c94a0c7
[THEMEUI][INF] Update German (de-DE) translation (#7489) 2024-11-18 21:24:57 +01:00
Serge Gautherie
9992fb183a
[SDK] d3dkmthk.h: Fix an '#ifdef __REACTOS__' (#7474)
Addendum to commit 6907831.

- Reverse inclusion.
- Remove copypasta about WDDM version.
2024-11-18 21:24:24 +01:00
Whindmar Saksit
2834e5b3c8
[RAPPS] Initialize SHBrowseForFolder to current download folder (#7505) 2024-11-18 16:42:43 +01:00
Doug Lyons
e0759a5e35
[NTOS:MM] Finish MmAllocateMappingAddress and MmFreeMappingAddress and fix test failures. (#7491)
* [NTOS:MM] Fix MmAllocateMappingAddress and MmFreeMappingAddress and their regression test failures.
Follow up of #7260.
This fixes kmtest:MmReservedMapping failures and hang.
Based on mm-implement-mappingaddress.patch by Thomas Faber and some changes by Oleg Dubinskiy.
kmtest:MmReservedMapping revisions and updates to Vista+ method by Timo Kreuzer.

Signed-off-by: Oleg Dubinskiy <oleg.dubinskij30@gmail.com>
Signed-off-by: Timo Kreuzer <timo.kreuzer@reactos.org>

CORE-10147, CORE-14635, CORE-17409, CORE-19318
2024-11-18 02:44:51 -06:00
Timo Kreuzer
31334ebcfe [SETUPLIB] Use proper SEH instead of nasty hacks
Addendum to commit 2268b3d
2024-11-18 10:23:50 +02:00
Whindmar Saksit
8107ff8636
[SHELL32][SHELL32_APITEST] Consolidate file type description handling (#7485)
- Fixes the case where an extension exists in HKCR but has no ProgId (half of CORE-19355)
- Fixes some cases where Wine hardcoded "File and "... file" strings are used instead of localized strings in SHGetFileInfo.
2024-11-17 20:13:05 +01:00
Hervé Poussineau
997b1797f4 [BATTC] Fix comparisons when choosing to complete the status IRP
They were reversed, which meant to immediately complete the IRP
if conditions were NOT satisfied.

Remove a now useless/invalid call to QueryStatus, to return the
status which lead to IRP completion.
2024-11-16 23:33:41 +01:00
Timo Kreuzer
9dedcb67e9 [VCRUNTIME][CRT] Change WCHAR_MIN/WCHAR_MAX to match native headers
This avoids conflicting definitions with MS CRT headers.
2024-11-16 20:01:49 +02:00
Timo Kreuzer
53d3cc5f3f [VCRUNTIME] stdint.h: Update include guard for MIN/MAX macros
Include MIN/MAX macros for C++11 and above without the need to define __STDC_LIMIT_MACROS. This is what mingw uses.
2024-11-16 20:01:49 +02:00
Timo Kreuzer
e5633f656f [VCRUNTIME] Add missing definitions 2024-11-16 20:01:49 +02:00
Timo Kreuzer
e202420456 [VCRUNTIME] Allow disabling GCC attributes for SAL 2024-11-16 20:01:49 +02:00
Timo Kreuzer
764cb5b8a5 [VCRUNTIME] Add pmmintrin.h 2024-11-16 20:01:49 +02:00
Timo Kreuzer
a67f36888c [VCRUNTIME] Fix emmintrin.h 2024-11-16 20:01:49 +02:00
Timo Kreuzer
f493606999 [VCRUNTIME] Add immintrin.h 2024-11-16 20:01:49 +02:00
Timo Kreuzer
be8bbcbe92 [VCRUNTIME] Add isa_availability.h 2024-11-16 20:01:49 +02:00
Timo Kreuzer
fb49e9126e [VCRUNTIME] Fix eh.h 2024-11-16 20:01:49 +02:00
Timo Kreuzer
b75d476bb7 [VCRUNTIME] Add __nullptr definition for non-MSVC compilers 2024-11-16 20:01:49 +02:00
Whindmar Saksit
6d109254ab
[SHELL32] Correctly compare pidls for SHBrowseForFolder BFFM_SETEXPANDED (#7499)
_ILIsEqualSimple just does a memcmp and that does not work for all items.

Should improve shell change notifications (CORE-13950).
2024-11-16 16:28:28 +01:00
Hervé Poussineau
81860b482a [CMBATT] Fix battery Tag
0 (ie BATTERY_TAG_INVALID) is not a valid battery tag.
First battery must have a tag of 1.
2024-11-12 21:26:42 +01:00
Hermès Bélusca-Maïto
6aa11ac494
[USETUP] Deduplicate code in SelectPartitionPage() 2024-11-10 18:45:58 +01:00
Hermès Bélusca-Maïto
5066818284
[USETUP] Deduplicate code in InstallDirectoryPage() 2024-11-10 18:45:57 +01:00
Hermès Bélusca-Maïto
8bb3e5a017
[USETUP] Minor simplifications in some branching code 2024-11-10 18:45:40 +01:00
Carlo Bramini
30b40247a3
[CALC] Fix copy command when output is NaN (#7496)
CORE-19745
2024-11-10 17:01:34 +01:00
Timo Kreuzer
0d6316b008 [CMAKE][LWIP] Fix build with newer CMake versions 2024-11-10 11:46:47 +02:00
Whindmar Saksit
9ccafe8e49
[SHELL32] Force FileType OpenWith verb (#7470)
CORE-19816
2024-11-09 16:49:27 +01:00
Whindmar Saksit
a17b6e9369
[SHELL32][BROWSEUI] Set DefView InvokeCommand directory (#7495)
If a .lnk shortcut does not specify a working directory, it should use the directory provided by the InvokeCommand caller when it's launced.

CORE-19855
2024-11-08 23:27:26 +01:00
Stanislav Motylkov
3ecd2363a6 [MSI][BOOTDATA][INF] Add missing mnemonic keys for the context menu
Also add accelerator FIXMEs where I don't know. CORE-12323
2024-11-06 00:34:58 +03:00
Stanislav Motylkov
6be0de5d7b [MSI][BOOTDATA][INF] Add missing localized strings to msi.dll resources 2024-11-06 00:26:18 +03:00
Stanislav Motylkov
3f4f51833a [BOOTDATA][INF] hivecls.inf: Update Russian (ru-RU) translation
CORE-19845
2024-11-05 23:30:15 +03:00
Stanislav Motylkov
b45429ce03 [BOOTDATA][INF] hivecls.inf: Add definitions for MSP / Msi.Patch files
These are used by Steinberg Cubase 5. CORE-19845
Also add some missing MUIVerb for Msi.Package.
2024-11-05 23:28:59 +03:00
Timo Kreuzer
51aac7ca93 [RTL] actctx.c: Restore wine tracing 2024-11-05 10:54:21 +02:00