Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-05 04:03:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Beautification and clarity

Co-authored-by: Victor Perevertkin <victor@perevertkin.ru>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
This commit is contained in:
Jérôme Gardou 2020-10-16 15:57:20 +02:00
parent c004b53d77
commit ab825334dd
5 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
base/services/tftpd/CMakeLists.txt
View file

@ -4,6 +4,6 @@ set_module_type(tftpd win32cui)
add_importlibs(tftpd advapi32 ws2_32 iphlpapi msvcrt kernel32) add_importlibs(tftpd advapi32 ws2_32 iphlpapi msvcrt kernel32)
add_cd_file(TARGET tftpd DESTINATION reactos/system32 FOR all) add_cd_file(TARGET tftpd DESTINATION reactos/system32 FOR all)
if((NOT MSVC) OR USE_CLANG_CL) if(GCC OR CLANG)
target_compile_options(tftpd PRIVATE -Wno-format-overflow) target_compile_options(tftpd PRIVATE -Wno-format-overflow)
endif() endif()

3
dll/3rdparty/libxslt/CMakeLists.txt vendored
View file

@ -43,10 +43,9 @@ if(MSVC)
add_importlibs(libxslt ntdll) add_importlibs(libxslt ntdll)
endif() endif()
if ((NOT MSVC) OR USE_CLANG_CL) if(GCC OR CLANG)
target_compile_options(libxslt PRIVATE -Wno-misleading-indentation -Wno-pointer-sign -Wno-unused-function) target_compile_options(libxslt PRIVATE -Wno-misleading-indentation -Wno-pointer-sign -Wno-unused-function)
endif() endif()
add_pch(libxslt precomp.h SOURCE) add_pch(libxslt precomp.h SOURCE)
add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all) add_cd_file(TARGET libxslt DESTINATION reactos/system32 FOR all)

6
sdk/lib/crt/msvcrtex.cmake
View file

@ -96,9 +96,9 @@ add_asm_files(msvcrtex_asm ${MSVCRTEX_ASM_SOURCE})
add_library(msvcrtex ${MSVCRTEX_SOURCE} ${msvcrtex_asm}) add_library(msvcrtex ${MSVCRTEX_SOURCE} ${msvcrtex_asm})
target_compile_definitions(msvcrtex PRIVATE _DLL _MSVCRTEX_) target_compile_definitions(msvcrtex PRIVATE _DLL _MSVCRTEX_)
if ((NOT MSVC) OR USE_CLANG_CL) if(GCC OR CLANG)
target_compile_options(msvcrtex PRIVATE $<$<COMPILE_LANGUAGE:C>:-Wno-main>) target_compile_options(msvcrtex PRIVATE $<$<COMPILE_LANGUAGE:C>:-Wno-main>)
if (LTCG) if(LTCG)
target_compile_options(msvcrtex PRIVATE -fno-lto) target_compile_options(msvcrtex PRIVATE -fno-lto)
endif() endif()
endif() endif()
@ -107,7 +107,7 @@ set_source_files_properties(startup/crtdll.c PROPERTIES COMPILE_DEFINITIONS CRTD
set_source_files_properties(startup/crtexe.c set_source_files_properties(startup/crtexe.c
startup/wcrtexe.c PROPERTIES COMPILE_DEFINITIONS _M_CEE_PURE) startup/wcrtexe.c PROPERTIES COMPILE_DEFINITIONS _M_CEE_PURE)
if (NOT MSVC) if(NOT MSVC)
target_link_libraries(msvcrtex oldnames) target_link_libraries(msvcrtex oldnames)
endif() endif()

2
sdk/tools/wpp/CMakeLists.txt
View file

@ -14,7 +14,7 @@ if(MSVC)
# Disable warnings # Disable warnings
add_compile_options( add_compile_options(
/wd4146 # " unary minus operator applied to unsigned type, result still unsigned" /wd4146 # "unary minus operator applied to unsigned type, result still unsigned"
/wd4244) # "'=': conversion from 'a' to 'b', possible loss of data" /wd4244) # "'=': conversion from 'a' to 'b', possible loss of data"
endif() endif()