[NTOSKRNL][RTL][DOC]

- Fix incorrect loop boundaries in the ARM version of MmCreateProcessAddressSpace. Spotted by Vincenzo Cotugno and cppcheck
- Correct outdated wineimport.cmd URL in README.WINE
- Assorted spelling and readability fixes

svn path=/trunk/; revision=53688

reactos/lib/rtl/i386/rtlmem.s

@@ -65,7 +65,7 @@ NotEqual:
 
 NotEqual2:
 
-    /* Remember how many mathced */
+    /* Remember how many matched */
     dec esi
     sub esi, [esp+12]
 

reactos/lib/rtl/path.c

@@ -489,7 +489,7 @@ RtlpDosPathNameToRelativeNtPathName_Ustr(IN BOOLEAN HaveRelative,
     else
     {
         /* Use the optimized path after acquiring the lock */
-        QuickPath = 1;
+        QuickPath = TRUE;
         NewBuffer = NULL;
     }
 

reactos/media/doc/README.WINE

@@ -270,7 +270,7 @@ User32 -
 Update process for autosync DLLs
 
 *** This process can only be done on Microsoft Windows ***
-- Download wineimport.cmd at svn://svn.reactos.org/reactos/trunk/tools/
+- Download wineimport.cmd at svn://svn.reactos.org/project-tools/trunk/
 - Download cvs command line program and be sure to put it in your path
   (available at http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/ )
 - Download svn command line program and be sure to put it in your path

reactos/ntoskrnl/ex/i386/fastinterlck_asm.S

@@ -37,7 +37,7 @@ PUBLIC @ExInterlockedAddLargeStatistic@8
     lock add [ecx], edx
 
     /* Check for carry bit and return */
-    jb .l1
+    jc .l1
     ret
 
 .l1:
@@ -82,7 +82,7 @@ _ExpInterlockedPopEntrySListResume@0:
     or eax, eax
     jz .l7
 
-    /* Copy sequence number and adjust it */
+    /* Copy depth and adjust it */
     lea ecx, [edx-1]
 
     /* Get next pointer and do the exchange */
@@ -167,7 +167,7 @@ PUBLIC @ExInterlockedFlushSList@4
     or eax, eax
     jz .l10
 
-    /* Clear sequence and pointer */
+    /* Clear depth and pointer */
     mov ecx, edx
     mov cx, bx
 

reactos/ntoskrnl/ke/spinlock.c

@@ -291,7 +291,7 @@ VOID
 FASTCALL
 KiReleaseSpinLock(IN PKSPIN_LOCK SpinLock)
 {
-    /* Do the lined function */
+    /* Do the inlined function */
     KxReleaseSpinLock(SpinLock);
 }
 

reactos/ntoskrnl/mm/ARM3/mdlsup.c

@@ -553,7 +553,7 @@ MmUnmapLockedPages(IN PVOID BaseAddress,
             // Get the new base address
             //
             BaseAddress = (PVOID)((ULONG_PTR)BaseAddress -
-                                  ((*MdlPages) << PAGE_SHIFT));
+                                  (*MdlPages << PAGE_SHIFT));
         }
 
         //
@@ -614,7 +614,7 @@ MmProbeAndLockPages(IN PMDL Mdl,
     // Get page and base information
     //
     MdlPages = (PPFN_NUMBER)(Mdl + 1);
-    Base = (PVOID)Mdl->StartVa;
+    Base = Mdl->StartVa;
 
     //
     // Get the addresses and how many pages we span (and need to lock)
@@ -840,7 +840,7 @@ MmProbeAndLockPages(IN PMDL Mdl,
                (PointerPte->u.Hard.Valid == 0))
         {
             //
-            // What kind of lock where we using?
+            // What kind of lock were we using?
             //
             if (UsePfnLock)
             {
@@ -870,7 +870,7 @@ MmProbeAndLockPages(IN PMDL Mdl,
             }
 
             //
-            // Waht lock should we use?
+            // What lock should we use?
             //
             if (UsePfnLock)
             {
@@ -908,7 +908,7 @@ MmProbeAndLockPages(IN PMDL Mdl,
                     if (Address <= MM_HIGHEST_USER_ADDRESS)
                     {
                         //
-                        // What kind of lock where we using?
+                        // What kind of lock were we using?
                         //
                         if (UsePfnLock)
                         {
@@ -1040,7 +1040,7 @@ MmProbeAndLockPages(IN PMDL Mdl,
     } while (PointerPte <= LastPte);
 
     //
-    // What kind of lock where we using?
+    // What kind of lock were we using?
     //
     if (UsePfnLock)
     {
@@ -1068,7 +1068,7 @@ CleanupWithLock:
     ASSERT(!NT_SUCCESS(Status));
 
     //
-    // What kind of lock where we using?
+    // What kind of lock were we using?
     //
     if (UsePfnLock)
     {
@@ -1189,8 +1189,8 @@ MmUnlockPages(IN PMDL Mdl)
                     ASSERT(Pfn1->u2.ShareCount == 0);
 
                     /* Not supported yet */
-                    ASSERT(((Pfn1->u3.e1.PrototypePte == 0) &&
+                    ASSERT((Pfn1->u3.e1.PrototypePte == 0) &&
-                            (Pfn1->OriginalPte.u.Soft.Prototype == 0)));
+                            (Pfn1->OriginalPte.u.Soft.Prototype == 0));
 
                     /* One less page */
                     InterlockedExchangeAddSizeT(&MmSystemLockPagesCount, -1);
@@ -1225,8 +1225,8 @@ MmUnlockPages(IN PMDL Mdl)
                             ASSERT(Pfn1->u3.e1.PageLocation == ActiveAndValid);
 
                             /* Not supported yet */
-                            ASSERT(((Pfn1->u3.e1.PrototypePte == 0) &&
+                            ASSERT((Pfn1->u3.e1.PrototypePte == 0) &&
-                                    (Pfn1->OriginalPte.u.Soft.Prototype == 0)));
+                                    (Pfn1->OriginalPte.u.Soft.Prototype == 0));
 
                             /* But there is one less "locked" page though */
                             InterlockedExchangeAddSizeT(&MmSystemLockPagesCount, -1);
@@ -1307,7 +1307,7 @@ MmUnlockPages(IN PMDL Mdl)
 
         /* Save the PFN entry instead for the secondary loop */
         *MdlPages = (PFN_NUMBER)MiGetPfnEntry(*MdlPages);
-        ASSERT((*MdlPages) != 0);
+        ASSERT(*MdlPages != 0);
     } while (++MdlPages < LastPage);
 
     //
@@ -1322,7 +1322,7 @@ MmUnlockPages(IN PMDL Mdl)
     do
     {
         /* Get the current entry and reference count */
-        Pfn1 = (PMMPFN)(*MdlPages);
+        Pfn1 = (PMMPFN)*MdlPages;
         OldRefCount = Pfn1->u3.e2.ReferenceCount;
         ASSERT(OldRefCount != 0);
 
@@ -1400,8 +1400,8 @@ NTAPI
 MmAdvanceMdl(IN PMDL Mdl,
              IN ULONG NumberOfBytes)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
-	return STATUS_NOT_IMPLEMENTED;
+    return STATUS_NOT_IMPLEMENTED;
 }
 
 /*
@@ -1414,8 +1414,8 @@ MmMapLockedPagesWithReservedMapping(IN PVOID MappingAddress,
                                     IN PMDL MemoryDescriptorList,
                                     IN MEMORY_CACHING_TYPE CacheType)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
-	return 0;
+    return 0;
 }
 
 /*
@@ -1427,7 +1427,7 @@ MmUnmapReservedMapping(IN PVOID BaseAddress,
                        IN ULONG PoolTag,
                        IN PMDL MemoryDescriptorList)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
 }
 
 /*
@@ -1438,8 +1438,8 @@ NTAPI
 MmPrefetchPages(IN ULONG NumberOfLists,
                 IN PREAD_LIST *ReadLists)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
-	return STATUS_NOT_IMPLEMENTED;
+    return STATUS_NOT_IMPLEMENTED;
 }
 
 /*
@@ -1450,8 +1450,8 @@ NTAPI
 MmProtectMdlSystemAddress(IN PMDL MemoryDescriptorList,
                           IN ULONG NewProtect)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
-	return STATUS_NOT_IMPLEMENTED;
+    return STATUS_NOT_IMPLEMENTED;
 }
 
 /*
@@ -1464,7 +1464,7 @@ MmProbeAndLockProcessPages(IN OUT PMDL MemoryDescriptorList,
                            IN KPROCESSOR_MODE AccessMode,
                            IN LOCK_OPERATION Operation)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
 }
 
 
@@ -1478,7 +1478,7 @@ MmProbeAndLockSelectedPages(IN OUT PMDL MemoryDescriptorList,
                             IN KPROCESSOR_MODE AccessMode,
                             IN LOCK_OPERATION Operation)
 {
-	UNIMPLEMENTED;
+    UNIMPLEMENTED;
 }
 
 /*

reactos/ntoskrnl/mm/arm/stubs.c

@@ -306,7 +306,7 @@ MmCreateProcessAddressSpace(IN ULONG MinWs,
     // Loop two tables (Hyperspace and TTB). Each one is 16KB
     //
     //
-    for (i = 0; i < 8; i++)
+    for (i = 0; i < sizeof(Pfn) / sizeof(Pfn[0]); i++)
     {
         //
         // Allocate a page

reactos/ntoskrnl/ob/oblife.c

@@ -1100,7 +1100,7 @@ ObCreateObjectType(IN PUNICODE_STRING TypeName,
                                ObpTypeObjectType,
                                sizeof(OBJECT_TYPE),
                                KernelMode,
-                               (POBJECT_HEADER*)&Header);
+                               &Header);
     if (!NT_SUCCESS(Status))
     {
         /* Free the name and fail */