diff --git a/reactos/lib/rtl/i386/rtlmem.s b/reactos/lib/rtl/i386/rtlmem.s index 0925b966042..c5340b00fb8 100644 --- a/reactos/lib/rtl/i386/rtlmem.s +++ b/reactos/lib/rtl/i386/rtlmem.s @@ -65,7 +65,7 @@ NotEqual: NotEqual2: - /* Remember how many mathced */ + /* Remember how many matched */ dec esi sub esi, [esp+12] diff --git a/reactos/lib/rtl/path.c b/reactos/lib/rtl/path.c index 6b19214e6d7..470ac0917f3 100644 --- a/reactos/lib/rtl/path.c +++ b/reactos/lib/rtl/path.c @@ -489,7 +489,7 @@ RtlpDosPathNameToRelativeNtPathName_Ustr(IN BOOLEAN HaveRelative, else { /* Use the optimized path after acquiring the lock */ - QuickPath = 1; + QuickPath = TRUE; NewBuffer = NULL; } diff --git a/reactos/media/doc/README.WINE b/reactos/media/doc/README.WINE index 88845ebd574..1e9786eaa36 100644 --- a/reactos/media/doc/README.WINE +++ b/reactos/media/doc/README.WINE @@ -270,7 +270,7 @@ User32 - Update process for autosync DLLs *** This process can only be done on Microsoft Windows *** -- Download wineimport.cmd at svn://svn.reactos.org/reactos/trunk/tools/ +- Download wineimport.cmd at svn://svn.reactos.org/project-tools/trunk/ - Download cvs command line program and be sure to put it in your path (available at http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/ ) - Download svn command line program and be sure to put it in your path diff --git a/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S b/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S index 8de4260ab87..813e23503da 100644 --- a/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S +++ b/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S @@ -37,7 +37,7 @@ PUBLIC @ExInterlockedAddLargeStatistic@8 lock add [ecx], edx /* Check for carry bit and return */ - jb .l1 + jc .l1 ret .l1: @@ -82,7 +82,7 @@ _ExpInterlockedPopEntrySListResume@0: or eax, eax jz .l7 - /* Copy sequence number and adjust it */ + /* Copy depth and adjust it */ lea ecx, [edx-1] /* Get next pointer and do the exchange */ @@ -167,7 +167,7 @@ PUBLIC @ExInterlockedFlushSList@4 or eax, eax jz .l10 - /* Clear sequence and pointer */ + /* Clear depth and pointer */ mov ecx, edx mov cx, bx diff --git a/reactos/ntoskrnl/ke/spinlock.c b/reactos/ntoskrnl/ke/spinlock.c index 0a98b330fd0..39d92294e57 100644 --- a/reactos/ntoskrnl/ke/spinlock.c +++ b/reactos/ntoskrnl/ke/spinlock.c @@ -291,7 +291,7 @@ VOID FASTCALL KiReleaseSpinLock(IN PKSPIN_LOCK SpinLock) { - /* Do the lined function */ + /* Do the inlined function */ KxReleaseSpinLock(SpinLock); } diff --git a/reactos/ntoskrnl/mm/ARM3/mdlsup.c b/reactos/ntoskrnl/mm/ARM3/mdlsup.c index e7e613d5220..99317659205 100644 --- a/reactos/ntoskrnl/mm/ARM3/mdlsup.c +++ b/reactos/ntoskrnl/mm/ARM3/mdlsup.c @@ -553,7 +553,7 @@ MmUnmapLockedPages(IN PVOID BaseAddress, // Get the new base address // BaseAddress = (PVOID)((ULONG_PTR)BaseAddress - - ((*MdlPages) << PAGE_SHIFT)); + (*MdlPages << PAGE_SHIFT)); } // @@ -614,7 +614,7 @@ MmProbeAndLockPages(IN PMDL Mdl, // Get page and base information // MdlPages = (PPFN_NUMBER)(Mdl + 1); - Base = (PVOID)Mdl->StartVa; + Base = Mdl->StartVa; // // Get the addresses and how many pages we span (and need to lock) @@ -840,7 +840,7 @@ MmProbeAndLockPages(IN PMDL Mdl, (PointerPte->u.Hard.Valid == 0)) { // - // What kind of lock where we using? + // What kind of lock were we using? // if (UsePfnLock) { @@ -870,7 +870,7 @@ MmProbeAndLockPages(IN PMDL Mdl, } // - // Waht lock should we use? + // What lock should we use? // if (UsePfnLock) { @@ -908,7 +908,7 @@ MmProbeAndLockPages(IN PMDL Mdl, if (Address <= MM_HIGHEST_USER_ADDRESS) { // - // What kind of lock where we using? + // What kind of lock were we using? // if (UsePfnLock) { @@ -1040,7 +1040,7 @@ MmProbeAndLockPages(IN PMDL Mdl, } while (PointerPte <= LastPte); // - // What kind of lock where we using? + // What kind of lock were we using? // if (UsePfnLock) { @@ -1068,7 +1068,7 @@ CleanupWithLock: ASSERT(!NT_SUCCESS(Status)); // - // What kind of lock where we using? + // What kind of lock were we using? // if (UsePfnLock) { @@ -1189,8 +1189,8 @@ MmUnlockPages(IN PMDL Mdl) ASSERT(Pfn1->u2.ShareCount == 0); /* Not supported yet */ - ASSERT(((Pfn1->u3.e1.PrototypePte == 0) && - (Pfn1->OriginalPte.u.Soft.Prototype == 0))); + ASSERT((Pfn1->u3.e1.PrototypePte == 0) && + (Pfn1->OriginalPte.u.Soft.Prototype == 0)); /* One less page */ InterlockedExchangeAddSizeT(&MmSystemLockPagesCount, -1); @@ -1225,8 +1225,8 @@ MmUnlockPages(IN PMDL Mdl) ASSERT(Pfn1->u3.e1.PageLocation == ActiveAndValid); /* Not supported yet */ - ASSERT(((Pfn1->u3.e1.PrototypePte == 0) && - (Pfn1->OriginalPte.u.Soft.Prototype == 0))); + ASSERT((Pfn1->u3.e1.PrototypePte == 0) && + (Pfn1->OriginalPte.u.Soft.Prototype == 0)); /* But there is one less "locked" page though */ InterlockedExchangeAddSizeT(&MmSystemLockPagesCount, -1); @@ -1307,7 +1307,7 @@ MmUnlockPages(IN PMDL Mdl) /* Save the PFN entry instead for the secondary loop */ *MdlPages = (PFN_NUMBER)MiGetPfnEntry(*MdlPages); - ASSERT((*MdlPages) != 0); + ASSERT(*MdlPages != 0); } while (++MdlPages < LastPage); // @@ -1322,7 +1322,7 @@ MmUnlockPages(IN PMDL Mdl) do { /* Get the current entry and reference count */ - Pfn1 = (PMMPFN)(*MdlPages); + Pfn1 = (PMMPFN)*MdlPages; OldRefCount = Pfn1->u3.e2.ReferenceCount; ASSERT(OldRefCount != 0); @@ -1400,8 +1400,8 @@ NTAPI MmAdvanceMdl(IN PMDL Mdl, IN ULONG NumberOfBytes) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; } /* @@ -1414,8 +1414,8 @@ MmMapLockedPagesWithReservedMapping(IN PVOID MappingAddress, IN PMDL MemoryDescriptorList, IN MEMORY_CACHING_TYPE CacheType) { - UNIMPLEMENTED; - return 0; + UNIMPLEMENTED; + return 0; } /* @@ -1427,7 +1427,7 @@ MmUnmapReservedMapping(IN PVOID BaseAddress, IN ULONG PoolTag, IN PMDL MemoryDescriptorList) { - UNIMPLEMENTED; + UNIMPLEMENTED; } /* @@ -1438,8 +1438,8 @@ NTAPI MmPrefetchPages(IN ULONG NumberOfLists, IN PREAD_LIST *ReadLists) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; } /* @@ -1450,8 +1450,8 @@ NTAPI MmProtectMdlSystemAddress(IN PMDL MemoryDescriptorList, IN ULONG NewProtect) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; } /* @@ -1464,7 +1464,7 @@ MmProbeAndLockProcessPages(IN OUT PMDL MemoryDescriptorList, IN KPROCESSOR_MODE AccessMode, IN LOCK_OPERATION Operation) { - UNIMPLEMENTED; + UNIMPLEMENTED; } @@ -1478,7 +1478,7 @@ MmProbeAndLockSelectedPages(IN OUT PMDL MemoryDescriptorList, IN KPROCESSOR_MODE AccessMode, IN LOCK_OPERATION Operation) { - UNIMPLEMENTED; + UNIMPLEMENTED; } /* diff --git a/reactos/ntoskrnl/mm/arm/stubs.c b/reactos/ntoskrnl/mm/arm/stubs.c index 781ea284e05..4a25ec95e12 100644 --- a/reactos/ntoskrnl/mm/arm/stubs.c +++ b/reactos/ntoskrnl/mm/arm/stubs.c @@ -306,7 +306,7 @@ MmCreateProcessAddressSpace(IN ULONG MinWs, // Loop two tables (Hyperspace and TTB). Each one is 16KB // // - for (i = 0; i < 8; i++) + for (i = 0; i < sizeof(Pfn) / sizeof(Pfn[0]); i++) { // // Allocate a page diff --git a/reactos/ntoskrnl/ob/oblife.c b/reactos/ntoskrnl/ob/oblife.c index ad4d9f10ca3..724c7f57696 100644 --- a/reactos/ntoskrnl/ob/oblife.c +++ b/reactos/ntoskrnl/ob/oblife.c @@ -1100,7 +1100,7 @@ ObCreateObjectType(IN PUNICODE_STRING TypeName, ObpTypeObjectType, sizeof(OBJECT_TYPE), KernelMode, - (POBJECT_HEADER*)&Header); + &Header); if (!NT_SUCCESS(Status)) { /* Free the name and fail */