Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-07-06 22:01:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

[0.4.14][DBGHELP] Addendum to last commit CORE-17073 (#3257)

Browse source 
I do recommend to change in function SymSetSearchPath: the line
WCHAR* sp;
to
WCHAR* sp = NULL;

to avoid the following compiler warning, that I got only on carrier-releaser interestingly,

../dll/win32/dbghelp/dbghelp.c: In function 'SymSetSearchPath':
../dll/win32/dbghelp/dbghelp.c:244:9: error: 'sp' may be used uninitialized in this function [-Werror=uninitialized]
cc1: all warnings being treated as errors

but I did not get that error on compilation when building this locally on "GCC4.7.2 RosBE2.1.6"
or "GCC8.4.0 RosBE2.21", or "VS2010", or with the buildbits/testbots. Weird!
I have no clue, why carrier releaser does behave different here at all upon compilation!
This commit is contained in:
Joachim Henze 2021-07-10 12:54:32 +02:00
parent d3e301e28b
commit 651a011548
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
dll/win32/dbghelp/dbghelp.c
View file

@ -231,7 +231,7 @@ BOOL WINAPI SymSetSearchPath(HANDLE hProcess, PCSTR searchPath)
{
BOOL ret = FALSE;
unsigned len;
WCHAR* sp;
WCHAR* sp = NULL;
if (searchPath)
{