From 651a0115480848b51ad0c20c1e0226c6bd8925f0 Mon Sep 17 00:00:00 2001 From: Joachim Henze Date: Sat, 10 Jul 2021 12:54:32 +0200 Subject: [PATCH] [0.4.14][DBGHELP] Addendum to last commit CORE-17073 (#3257) I do recommend to change in function SymSetSearchPath: the line WCHAR* sp; to WCHAR* sp = NULL; to avoid the following compiler warning, that I got only on carrier-releaser interestingly, ../dll/win32/dbghelp/dbghelp.c: In function 'SymSetSearchPath': ../dll/win32/dbghelp/dbghelp.c:244:9: error: 'sp' may be used uninitialized in this function [-Werror=uninitialized] cc1: all warnings being treated as errors but I did not get that error on compilation when building this locally on "GCC4.7.2 RosBE2.1.6" or "GCC8.4.0 RosBE2.21", or "VS2010", or with the buildbits/testbots. Weird! I have no clue, why carrier releaser does behave different here at all upon compilation! --- dll/win32/dbghelp/dbghelp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/dbghelp/dbghelp.c b/dll/win32/dbghelp/dbghelp.c index 3c437e06dc0..d26faa10c72 100644 --- a/dll/win32/dbghelp/dbghelp.c +++ b/dll/win32/dbghelp/dbghelp.c @@ -231,7 +231,7 @@ BOOL WINAPI SymSetSearchPath(HANDLE hProcess, PCSTR searchPath) { BOOL ret = FALSE; unsigned len; - WCHAR* sp; + WCHAR* sp = NULL; if (searchPath) {