Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-08-04 01:25:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

[TASKMGR] Fix text cutoff statusbar2 CPU%, improve statusbar3 Mem (#5978)

Browse source 
ReactOS taskmgr writes a bit more *useful* dynamically
generated strings in the status-bar field 3 with the memory
than MS Windows XP taskmgr does for example.
Available space in the statusbar is very limited,
therefore we use the following trick to get as much as possible of that helpful text visible
for the majority of the translations:
- We do shrink the CPU% column a bit in width and static text lengths, as it is the one which
has very little variety in length of its dynamic part: 0% to 100%

This improves the display for all languages, and for some languages it also fixes
text-cutoff that we even had with the wider width in the CPU% column already.

also fix an accelerator collision in nl-NL.rc
This commit is contained in:
Joachim Henze 2023-11-27 18:53:34 +01:00 • committed by GitHub
parent 75c67f9b51
commit 628d4a92e9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
31 changed files with 36 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

10
base/applications/taskmgr/taskmgr.h
View file

@ -15,7 +15,7 @@
#define STATUS_WINDOW 2001
#define STATUS_SIZE1 85
#define STATUS_SIZE2 190
#define STATUS_SIZE2 157 // he-IL.rc determines minimum width: 72 == 157 - 85
#define STATUS_SIZE3 400
typedef struct
@ -36,15 +36,14 @@ typedef struct
BOOL HideWhenMinimized;
BOOL Show16BitTasks;
/* Update speed settings */
/* How many half-seconds in between updates (i.e. 0 - Paused, 1 - High, 2 - Normal, 4 - Low) */
/* 0 - Paused, 1 - High, 2 - Normal, 4 - Low */
DWORD UpdateSpeed;
/* Applications page settings */
DWORD ViewMode;
/* Processes page settings */
BOOL ShowProcessesFromAllUsers; /* Server-only? */
BOOL ShowProcessesFromAllUsers;
BOOL Columns[COLUMN_NMAX];
int ColumnOrderArray[COLUMN_NMAX];
int ColumnSizeArray[COLUMN_NMAX];
@ -54,7 +53,6 @@ typedef struct
/* Performance page settings */
BOOL CPUHistory_OneGraphPerCPU;
BOOL ShowKernelTimes;
} TASKMANAGER_SETTINGS, *LPTASKMANAGER_SETTINGS;
/* Global Variables: */
@ -82,5 +80,5 @@ void TaskManager_OnViewUpdateSpeed(DWORD);
void TaskManager_OnTabWndSelChange(void);
BOOL ConfirmMessageBox(HWND hWnd, LPCWSTR Text, LPCWSTR Title, UINT Type);
VOID ShowWin32Error(DWORD dwError);
LPTSTR GetLastErrorText( LPTSTR lpszBuf, DWORD dwSize );
LPTSTR GetLastErrorText(LPTSTR lpszBuf, DWORD dwSize);
DWORD EndLocalThread(HANDLE *hThread, DWORD dwThread);