xfnw/stagit
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix null pointer access for submodules in writefilestree

Browse source 
Do not try to set a link to submodules from bare repo as we can't get
the actual url.
This commit is contained in:
Quentin Rameau 2016-04-29 14:01:45 +02:00 committed by Hiltjo Posthuma
parent 375d41dcce
commit b8af751b01
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
stagit.c
View file

@ -709,13 +709,18 @@ writefilestree(FILE *fp, git_tree *tree, const char *branch, const char *path)
fprintf(fp, "%juB", (uintmax_t)filesize);
fputs("</td></tr>\n", fp);
} else if (git_submodule_lookup(&module, repo, entryname) == 0) {
moduleurl = git_submodule_url(module);
fprintf(fp, "<tr><td>m---------</td><td><a class=\"module\" href=\"%s\">",
moduleurl);
fputs("<tr><td>m---------</td><td>", fp);
if ((moduleurl = git_submodule_url(module))) {
fprintf(fp, "<a class=\"module\" href=\"%s\">",
moduleurl);
}
xmlencode(fp, entrypath, strlen(entrypath));
fputs(" @", fp);
xmlencode(fp, moduleurl, strlen(moduleurl));
fprintf(fp, "</a></td><td class=\"num\">0%c",
if (moduleurl) {
fputs(" @", fp);
xmlencode(fp, moduleurl, strlen(moduleurl));
fputs("</a>", fp);
}
fprintf(fp, "</td><td class=\"num\">0%c",
showlinecount ? 'L' : 'B');
git_submodule_free(module);
fputs("</td></tr>\n", fp);