improve commitinfo_getstats
- reorder: unnecessary allocation when git_patch_from_diff fails. - no need to free patch object when git_patch_from_diff fails.
This commit is contained in:
parent
8eabe24bdd
commit
8fa0effa98
7
stagit.c
7
stagit.c
|
@ -110,13 +110,10 @@ commitinfo_getstats(struct commitinfo *ci)
|
||||||
err(1, "calloc");
|
err(1, "calloc");
|
||||||
|
|
||||||
for (i = 0; i < ndeltas; i++) {
|
for (i = 0; i < ndeltas; i++) {
|
||||||
|
if (git_patch_from_diff(&patch, ci->diff, i))
|
||||||
|
goto err;
|
||||||
if (!(di = calloc(1, sizeof(struct deltainfo))))
|
if (!(di = calloc(1, sizeof(struct deltainfo))))
|
||||||
err(1, "calloc");
|
err(1, "calloc");
|
||||||
if (git_patch_from_diff(&patch, ci->diff, i)) {
|
|
||||||
git_patch_free(patch);
|
|
||||||
free(di);
|
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
di->patch = patch;
|
di->patch = patch;
|
||||||
ci->deltas[i] = di;
|
ci->deltas[i] = di;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue