xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

libsec: fix operator precedence bugs (thanks kemal)

Browse source
This commit is contained in:
cinap_lenrek 2021-10-17 23:35:37 +00:00
parent e0d2453f56
commit ee31c78080
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sys/src/libsec/port/tlshand.c
View file

@ -660,7 +660,7 @@ checkClientExtensions(TlsConnection *c, Bytes *ext)
goto Short; goto Short;
switch(get16(p-4)){ switch(get16(p-4)){
case Extec: case Extec:
if(n < 4 || n & 1 || get16(p) != (n -= 2)) if(n < 4 || n % 2 || get16(p) != (n -= 2))
goto Short; goto Short;
p += 2; p += 2;
for(i = 0; i < nelem(namedcurves) && c->sec->nc == nil; i++) for(i = 0; i < nelem(namedcurves) && c->sec->nc == nil; i++)
@ -1574,7 +1574,7 @@ msgRecv(TlsConnection *c, Msg *m)
nn = get16(p); nn = get16(p);
p += 2, n -= 2; p += 2, n -= 2;
if((nn & 1) || n < nn || nn < 2) if(nn % 2 || n < nn || nn < 2)
goto Short; goto Short;
m->u.clientHello.ciphers = newints(nn >> 1); m->u.clientHello.ciphers = newints(nn >> 1);
for(i = 0; i < nn; i += 2) for(i = 0; i < nn; i += 2)
@ -1663,7 +1663,7 @@ msgRecv(TlsConnection *c, Msg *m)
goto Short; goto Short;
nn = get16(p); nn = get16(p);
p += 2, n -= 2; p += 2, n -= 2;
if(nn & 1) if(nn % 2)
goto Short; goto Short;
m->u.certificateRequest.sigalgs = newints(nn>>1); m->u.certificateRequest.sigalgs = newints(nn>>1);
for(i = 0; i < nn; i += 2) for(i = 0; i < nn; i += 2)