xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

upas/fs: fix swapped argument, dead code

Browse source 
With ntlm auth, we were trying to set 0 bytes of
the auth struct to its size. The args were clearly
swapped. Fix it.

While we're here, remove some dead code.
This commit is contained in:
Ori Bernstein 2021-01-23 18:02:46 -08:00
parent f164ee6dd9
commit ed2b1d5c61
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sys/src/cmd/upas/fs/imap.c
View file

@ -687,8 +687,7 @@ imap4ntlm(Imap *imap)
return "auth_respond failed"; return "auth_respond failed";
/* prepare NtLmAuthenticate blob */ /* prepare NtLmAuthenticate blob */
memset(buf, 0, sizeof(buf));
memset(buf, sizeof buf, 0);
p = buf; p = buf;
ep = p + 8 + 6*8 + 2*4; ep = p + 8 + 6*8 + 2*4;
q = ep; q = ep;
@ -852,14 +851,6 @@ imap4dial(Imap *imap)
return nil; return nil;
} }
static void
imap4hangup(Imap *imap)
{
imap4cmd(imap, "logout");
imap4resp(imap);
imap4disconnect(imap);
}
/* gmail lies about message sizes */ /* gmail lies about message sizes */
static ulong static ulong
gmaildiscount(Message *m, uvlong o, ulong l) gmaildiscount(Message *m, uvlong o, ulong l)