devenv: simplify envremove(), cleanup

This commit is contained in:
cinap_lenrek 2015-08-03 22:08:10 +02:00
parent 37e4ce0ea7
commit d5d6724805

View file

@ -192,28 +192,24 @@ static void
envremove(Chan *c)
{
Egrp *eg;
Evalue *e, *ee;
Evalue *e;
if(c->qid.type & QTDIR || !envwriteable(c))
error(Eperm);
eg = envgrp(c);
wlock(eg);
e = eg->ent;
for(ee = e + eg->nent; e < ee; e++){
if(e->qid.path == c->qid.path){
free(e->name);
free(e->value);
*e = ee[-1];
eg->nent--;
eg->vers++;
wunlock(eg);
return;
}
}
e = envlookup(eg, nil, c->qid.path);
if(e == nil){
wunlock(eg);
error(Enonexist);
}
free(e->name);
free(e->value);
*e = eg->ent[--eg->nent];
eg->vers++;
wunlock(eg);
}
static void
envclose(Chan *c)