xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

cc: fix non constant pointer initializer for other compilers than 8c/6c

Browse source 
i made a mistake here as this change breaks the arm and mips compilers
which lack an optimiation in xcom() that folds constant pointer arithmetic
into the offset. on arm, the a node is a complex expression with op OADD of
type TIND but the test rejected the (valid) pointer arithmetic.

instead, we now test for the operations which cannot be constant instead
of using the type as a proxy.
This commit is contained in:
cinap_lenrek 2015-04-23 05:12:57 +02:00
parent 7f0728b7f4
commit c1ff805e23
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
sys/src/cmd/cc/dcl.c
View file

@ -381,11 +381,12 @@ init1(Sym *s, Type *t, long o, int exflag)
diag(a, "initialization of incompatible pointers: %s\n%T and %T",
s->name, t, a->type);
}
if(a->op == OADDR) {
switch(a->op) {
case OADDR:
a = a->left;
goto gext;
}
if(a->type->etype == TIND) {
break;
case ONAME:
case OIND:
diag(a, "initializer is not a constant: %s", s->name);
return Z;
}