xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

mk: remove buggy and unneeded syminit() function (thanks qurstuv)

Browse source 
syminit() attemts to reset the symbol table by freeing
all the hash table entries, tho the code is buggy having
a obviously use after free bug.

as syminit() is only called once in main when it does not
contain any symbols, the bug never occured.

removing the unneccesary code alltogether.
This commit is contained in:
cinap_lenrek 2016-06-01 18:31:21 +02:00
parent 68571320fa
commit b878450725
3 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
sys/src/cmd/mk/fns.h
View file

@ -65,7 +65,6 @@ void shprint(char*, Envy*, Bufblock*);
Word *stow(char*);
void subst(char*, char*, char*, int);
void symdel(char*, int);
void syminit(void);
Symtab *symlook(char*, int, void*);
void symstat(void);
void symtraverse(int, void(*)(Symtab*));

1
sys/src/cmd/mk/main.c
View file

@ -119,7 +119,6 @@ main(int argc, char **argv)
if(aflag)
iflag = 1;
usage();
syminit();
initenv();
usage();

12
sys/src/cmd/mk/symtab.c
View file

@ -4,18 +4,6 @@
#define HASHMUL 79L /* this is a good value */
static Symtab *hash[NHASH];
void
syminit(void)
{
Symtab **s, *ss;
for(s = hash; s < &hash[NHASH]; s++){
for(ss = *s; ss; ss = ss->next)
free((char *)ss);
*s = 0;
}
}
Symtab *
symlook(char *sym, int space, void *install)
{