xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

libsec: fix missing error case unlock() in tlshands initCiphers()

Browse source
This commit is contained in:
cinap_lenrek 2016-02-07 00:31:30 +01:00
parent faecd86ee6
commit b63a6bf626
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sys/src/libsec/port/tlshand.c
View file

@ -1133,7 +1133,7 @@ tlsClient2(int ctl, int hand,
goto Err;
}
if(setVersion(c, m.u.serverHello.version) < 0) {
tlsError(c, EIllegalParameter, "incompatible version %r");
tlsError(c, EIllegalParameter, "incompatible version: %r");
goto Err;
}
memmove(c->srandom, m.u.serverHello.random, RandomSize);
@ -2321,13 +2321,13 @@ initCiphers(void)
j = open("#a/tls/encalgs", OREAD);
if(j < 0){
werrstr("can't open #a/tls/encalgs: %r");
return 0;
goto out;
}
n = read(j, s, MaxAlgF-1);
close(j);
if(n <= 0){
werrstr("nothing in #a/tls/encalgs: %r");
return 0;
goto out;
}
s[n] = 0;
n = getfields(s, flds, MaxAlgs, 1, " \t\r\n");
@ -2345,13 +2345,13 @@ initCiphers(void)
j = open("#a/tls/hashalgs", OREAD);
if(j < 0){
werrstr("can't open #a/tls/hashalgs: %r");
return 0;
goto out;
}
n = read(j, s, MaxAlgF-1);
close(j);
if(n <= 0){
werrstr("nothing in #a/tls/hashalgs: %r");
return 0;
goto out;
}
s[n] = 0;
n = getfields(s, flds, MaxAlgs, 1, " \t\r\n");
@ -2367,6 +2367,7 @@ initCiphers(void)
if(cipherAlgs[i].ok)
nciphers++;
}
out:
unlock(&ciphLock);
return nciphers;
}