From b6381141861419f8cf2a11e3c2ff605755a5becc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Igor=20B=C3=B6hm?= Date: Sat, 25 Sep 2021 20:40:47 +0000 Subject: [PATCH] vncv: enable connecting to Darwin hosts Tested on MacOS Catalina and Big Sur releases. Update man page to highlight weak encryption of vnc, recommending to tunnel via ssh (thanks unobe). --- sys/man/1/vnc | 9 ++++++--- sys/src/cmd/vnc/auth.c | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/man/1/vnc b/sys/man/1/vnc index 0a2dc9a39..7ba8b1b49 100644 --- a/sys/man/1/vnc +++ b/sys/man/1/vnc @@ -201,9 +201,12 @@ print verbose output to standard error. If the remote frame buffer is larger than the local screen, only the upper left corner can be accessed. .PP +.I Vncs +and +.I vncv +encryption is not secure. It's advisable to tunnel through +ssh or some other secure protocol. +.PP .I Vncv does no verification of the TLS certificate presented by the server. -.PP -.I Vncv -supports only version 3.3 of the RFB protocol. diff --git a/sys/src/cmd/vnc/auth.c b/sys/src/cmd/vnc/auth.c index 806c830bf..edde1ba85 100644 --- a/sys/src/cmd/vnc/auth.c +++ b/sys/src/cmd/vnc/auth.c @@ -33,6 +33,8 @@ vnchandshake(Vnc *v) v->vers = 37; else if(strncmp(msg, "RFB 003.008\n", VerLen) == 0) v->vers = 38; + else if(strncmp(msg, "RFB 003.889\n", VerLen) == 0) + v->vers = 38; /* Darwin */ else /* RFC6143: Any other should be treated as 3.3. */ v->vers = 33;