libc: recurse on smaller half of array
Our qsort has an optimization to recurse on one half of the array, and do a tail call on the other half. Unfortunately, the condition deciding which half of the array to recurse on was wrong, so we were recursing on the larger half of the array and iterating on the smaller half. This meant that if we picked the partition poorly, we were pessimizing our stack usage instead of optimizing it. This change reduces our stack usage from O(n) to O(log(n)) for poorly chosen pivots.
This commit is contained in:
parent
51b22d8548
commit
b5086c1863
1 changed files with 1 additions and 1 deletions
|
@ -100,7 +100,7 @@ qsorts(char *a, long n, Sort *p)
|
||||||
j = (pj - a) / es;
|
j = (pj - a) / es;
|
||||||
|
|
||||||
n = n-j-1;
|
n = n-j-1;
|
||||||
if(j >= n) {
|
if(j < n) {
|
||||||
qsorts(a, j, p);
|
qsorts(a, j, p);
|
||||||
a += (j+1)*es;
|
a += (j+1)*es;
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in a new issue