xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ether82557: don't turn off promisc mode when mcast table is not empty

Browse source 
the driver doesnt implement multicast filter, but just turns
on promiscuous mode when a multicast address is added. but this
breaks when one actually enables and then disables promiscuous
mode with say, running snoopy.

we have to keep promisc mode active as long as multicast table
is not empty.
This commit is contained in:
cinap_lenrek 2018-01-13 07:16:17 +01:00
parent ba87e58876
commit ad36593a99
1 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
sys/src/9/pc/ether82557.c
View file

@ -588,20 +588,15 @@ configure(Ether* ether, int promiscuous)
static void
promiscuous(void* arg, int on)
{
configure(arg, on);
Ether *ether = arg;
configure(ether, on || ether->nmaddr > 0);
}
static void
multicast(void* ether, uchar *addr, int add)
multicast(void* arg, uchar *, int)
{
USED(addr);
/*
* TODO: if (add) add addr to list of mcast addrs in controller
* else remove addr from list of mcast addrs in controller
* enable multicast input (see CbMAS) instead of promiscuous mode.
*/
if (add)
configure(ether, 1);
Ether *ether = arg;
configure(ether, ether->prom || ether->nmaddr > 0);
}
static void