xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

deroff: fix out-of-bounds access if runes above 0X80 are inside EQ clauses (thanks mmnmnnmnmm, via plan9port)

Browse source 
Characters greater than 0X80 will cause a read beyond the bounds of the
array chars[]. For particular unicode characters this can cause deroff
to segfault.

A minimal example:
$ deroff
.EQ
u∈
Segmentation fault

Throughout deroff, charclass() is used instead of directly indexing
chars[] so I presume this was just missed.
This commit is contained in:
Ori Bernstein 2020-08-01 10:54:03 -07:00
parent 6dbecfb457
commit 9e27ee094c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/src/cmd/deroff.c
View file

@ -745,7 +745,7 @@ eqn(void)
} }
if(c != '\n') if(c != '\n')
while(C1 != '\n') { while(C1 != '\n') {
if(chars[c] == PUNCT) if(charclass(c) == PUNCT)
last = c; last = c;
else else
if(c != ' ') if(c != ' ')