xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

8c: fix double compiling FNX complex lvalue in cgen64()

Browse source 
sugen() calls cgen64() speculatively so that when cgen64() returns
zero, it will fall back and compile 64-bit copy.

the bug was that cgen64() compiled the left hand side and then recursively
called cgen64() again, which didnt handle the memory copy so it returned
zero and sugen() would compile the left hand side again resulting in two
function calls being emited.

some code that reproduced the issue:

#include <u.h>
#include <libc.h>

typedef struct
{
	char x[10];
	vlong a;
} X;

X a;
X *f(void) { return &a; }

void
main(int argc, char *argv[])
{
	f()->a = a.a;
}

producing:

TEXT	f+0(SB),0,$0
	MOVL	$a+0(SB),AX
	RET	,
	RET	,
	TEXT	main+0(SB),0,$0
	CALL	,f+0(SB)
	CALL	,f+0(SB)			<- bug
	MOVL	AX,CX
	LEAL	a+12(SB),DX
	MOVL	(DX),AX
	MOVL	AX,12(CX)
	MOVL	4(DX),AX
	MOVL	AX,16(CX)
	RET	,
	GLOBL	a+0(SB),$20
	END	,
This commit is contained in:
cinap_lenrek 2016-10-30 23:30:13 +01:00
parent 62d3108646
commit 95609d520e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sys/src/cmd/8c/cgen64.c
View file

@ -1577,9 +1577,9 @@ cgen64(Node *n, Node *nn)
if(nn != Z && nn->complex >= FNX){ if(nn != Z && nn->complex >= FNX){
reglcgen(&nod1, nn, Z); reglcgen(&nod1, nn, Z);
m = cgen64(n, &nod1); cgen(n, &nod1);
regfree(&nod1); regfree(&nod1);
return m; return 1;
} }
switch(n->op) { switch(n->op) {