xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

gs: avoid 6c type propagation / constant folding issue for set_cb_end()

Browse source 
6c changed "- cmd_lagest_size + 1" into a *unsigned* 32bit constant. which
got added to 64bit pointer making pcb->limit > pcb->end resulting
in errors for partial commands in the buffer. removing the parentesis
propagates the operation to 64bit.
This commit is contained in:
cinap_lenrek 2015-04-17 06:18:43 +02:00
parent 57ad566dfc
commit 81cbff917f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/src/cmd/gs/src/gxclrast.c
View file

@ -119,7 +119,7 @@ private void
set_cb_end(command_buf_t *pcb, const byte *end) set_cb_end(command_buf_t *pcb, const byte *end)
{ {
pcb->end = end; pcb->end = end;
pcb->limit = pcb->data + (pcb->size - cmd_largest_size + 1); pcb->limit = pcb->data + pcb->size - cmd_largest_size + 1;
if ( pcb->limit > pcb->end ) if ( pcb->limit > pcb->end )
pcb->limit = pcb->end; pcb->limit = pcb->end;
} }