xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

libauth: simplify _attrfmt() using fmtprint() avoiding stack buffer

Browse source
This commit is contained in:
cinap_lenrek 2018-01-02 04:47:42 +01:00
parent e1ca49d625
commit 77ad456b31
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
sys/src/libauth/attr.c
View file

@ -5,28 +5,26 @@
int
_attrfmt(Fmt *fmt)
{
char *b, buf[1024], *ebuf;
Attr *a;
int first = 1;
ebuf = buf+sizeof buf;
b = buf;
strcpy(buf, " ");
for(a=va_arg(fmt->args, Attr*); a; a=a->next){
for(a=va_arg(fmt->args, Attr*); a != nil; a=a->next){
if(a->name == nil)
continue;
switch(a->type){
default:
continue;
case AttrQuery:
b = seprint(b, ebuf, " %q?", a->name);
fmtprint(fmt, first+" %q?", a->name);
break;
case AttrNameval:
b = seprint(b, ebuf, " %q=%q", a->name, a->val);
break;
case AttrDefault:
b = seprint(b, ebuf, " %q:=%q", a->name, a->val);
fmtprint(fmt, first+" %q=%q", a->name, a->val);
break;
}
first = 0;
}
return fmtstrcpy(fmt, buf+1);
return 0;
}
Attr*