xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

usbxhci: fix mistake in completering()

Browse source 
the td index "x" was incremented twice, once in for loop
and in the body expression. so r->rp only got updated
every second completion. this is wrong, but harmless.
This commit is contained in:
cinap_lenrek 2018-02-07 18:13:22 +01:00
parent c5c159b17a
commit 650e5db5a2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/src/9/pc/usbxhci.c
View file

@ -800,7 +800,7 @@ completering(Ring *r, u32int *er)
pa = (*(u64int*)er) & ~15ULL; pa = (*(u64int*)er) & ~15ULL;
ilock(r); ilock(r);
for(x = r->rp; (int)(r->wp - x) > 0; x++){ for(x = r->rp; (int)(r->wp - x) > 0;){
td = &r->base[4*(x++ & r->mask)]; td = &r->base[4*(x++ & r->mask)];
if((u64int)PADDR(td) == pa){ if((u64int)PADDR(td) == pa){
r->rp = x; r->rp = x;