xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

cron: just run /bin/rx to execute remote commands

Browse source
This commit is contained in:
cinap_lenrek 2016-02-14 05:59:42 +01:00
parent 373723d4f6
commit 61dea9012e
1 changed files with 17 additions and 61 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

78
sys/src/cmd/auth/cron.c
View file

@ -500,23 +500,6 @@ gettok(int min, int max)
} }
} }
int
call(char *host)
{
char *na, *p;
na = netmkaddr(host, 0, "rexexec");
p = utfrune(na, L'!');
if(!p)
return -1;
p = utfrune(p+1, L'!');
if(!p)
return -1;
if(strcmp(p, "!rexexec") != 0)
return -2;
return dial(na, 0, 0, 0);
}
/* /*
* convert command to run properly on the remote machine * convert command to run properly on the remote machine
* need to escape the quotes so they don't get stripped * need to escape the quotes so they don't get stripped
@ -553,8 +536,6 @@ void
rexec(User *user, Job *j) rexec(User *user, Job *j)
{ {
char buf[8*1024]; char buf[8*1024];
int n, fd;
AuthInfo *ai;
switch(rfork(RFPROC|RFNOWAIT|RFNAMEG|RFENVG|RFFDG)){ switch(rfork(RFPROC|RFNOWAIT|RFNAMEG|RFENVG|RFFDG)){
case 0: case 0:
@ -570,54 +551,29 @@ rexec(User *user, Job *j)
_exits(0); _exits(0);
} }
/*
* local call, auth, cmd with no i/o
*/
if(strcmp(j->host, "local") == 0){
if(becomeuser(user->name) < 0){
clog("%s: can't change uid for %s on %s: %r",
user->name, j->cmd, j->host);
_exits(0);
}
putenv("service", "rx");
clog("%s: ran '%s' on %s", user->name, j->cmd, j->host);
execl("/bin/rc", "rc", "-lc", buf, nil);
clog("%s: exec failed for %s on %s: %r",
user->name, j->cmd, j->host);
_exits(0);
}
/*
* remote call, auth, cmd with no i/o
* give it 2 min to complete
*/
alarm(2*Minute*1000);
fd = call(j->host);
if(fd < 0){
if(fd == -2)
clog("%s: dangerous host %s", user->name, j->host);
clog("%s: can't call %s: %r", user->name, j->host);
_exits(0);
}
clog("%s: called %s on %s", user->name, j->cmd, j->host);
if(becomeuser(user->name) < 0){ if(becomeuser(user->name) < 0){
clog("%s: can't change uid for %s on %s: %r", clog("%s: can't change uid for %s on %s: %r",
user->name, j->cmd, j->host); user->name, j->cmd, j->host);
_exits(0); _exits(0);
} }
ai = auth_proxy(fd, nil, "proto=p9any role=client");
if(ai == nil){ clog("%s: ran '%s' on %s", user->name, j->cmd, j->host);
clog("%s: can't authenticate for %s on %s: %r",
user->name, j->cmd, j->host); close(0);
_exits(0); close(1);
} close(2);
clog("%s: authenticated %s on %s", user->name, j->cmd, j->host); open("/dev/null", OREAD);
write(fd, buf, strlen(buf)+1); open("/dev/null", OWRITE);
write(fd, buf, 0); open("/dev/null", OWRITE);
while((n = read(fd, buf, sizeof(buf)-1)) > 0){
buf[n] = 0; if(strcmp(j->host, "local") == 0){
clog("%s: %s\n", j->cmd, buf); putenv("service", "rx");
execl("/bin/rc", "rc", "-lc", buf, nil);
} else {
execl("/bin/rx", "rx", j->host, buf, nil);
} }
clog("%s: exec failed for %s on %s: %r", user->name, j->cmd, j->host);
_exits(0); _exits(0);
} }