xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

snap: be more conservative taking stack snapshot

Browse source 
include up to 8k below the stack to get some more context.

don't assume stack is at least 16K.
This commit is contained in:
cinap_lenrek 2018-11-22 10:30:45 +01:00
parent 1f464e0013
commit 5692788724
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
sys/src/cmd/snap/take.c
View file

@ -20,7 +20,7 @@ sumr(ulong sum, void *buf, int n)
return sum;
}
static int npage;
static ulong npage;
static Page *pgtab[1<<10];
Page*
@ -32,7 +32,7 @@ datapage(char *p, long len)
int iszero;
if(len > Pagesize) {
fprint(2, "datapage cannot handle pages > 1024\n");
fprint(2, "datapage cannot handle pages > %d\n", Pagesize);
exits("datapage");
}
@ -277,14 +277,14 @@ snap(long pid, int usetext)
if(stacklen) {
sp = stackptr(proc, fd);
if(stackoff <= sp && sp < stackoff+stacklen) {
off = (sp - Pagesize) & ~(Pagesize - 1);
if(off < stackoff)
off = stackoff;
len = stacklen - (off - stackoff);
off = sp - 8*1024;
} else { /* stack pointer not in segment. thread library? */
off = stackoff + stacklen - 16*1024;
len = 16*1024;
}
off &= ~((uvlong)Pagesize-1);
if(off < stackoff)
off = stackoff;
len = stacklen - (off - stackoff);
s[stacki] = readseg(fd, off, len, "Stack");
}