xfnw/plan9fox
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

exportfs: simplify freefile() code

Browse source 
remove impossible checks, rewrite as while loop.
This commit is contained in:
cinap_lenrek 2014-08-02 19:22:10 +02:00
parent b185d2fe5c
commit 5302e88796
1 changed files with 19 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

16
sys/src/cmd/exportfs/exportfs.c
View file

@ -587,30 +587,25 @@ freefile(File *f)
{ {
File *parent, *child; File *parent, *child;
Loop: while(--f->ref == 0){
f->ref--;
if(f->ref > 0)
return;
freecnt++; freecnt++;
if(f->ref < 0) abort();
DEBUG(DFD, "free %s\n", f->name); DEBUG(DFD, "free %s\n", f->name);
/* delete from parent */ /* delete from parent */
parent = f->parent; parent = f->parent;
if(parent->child == f) if(parent->child == f)
parent->child = f->childlist; parent->child = f->childlist;
else{ else{
for(child=parent->child; child->childlist!=f; child=child->childlist) for(child = parent->child; child->childlist != f; child = child->childlist) {
if(child->childlist == nil) if(child->childlist == nil)
fatal("bad child list"); fatal("bad child list");
}
child->childlist = f->childlist; child->childlist = f->childlist;
} }
freeqid(f->qidt); freeqid(f->qidt);
free(f->name); free(f->name);
f->name = nil;
free(f); free(f);
f = parent; f = parent;
if(f != nil) }
goto Loop;
} }
File * File *
@ -744,8 +739,7 @@ freeqid(Qidtab *q)
ulong h; ulong h;
Qidtab *l; Qidtab *l;
q->ref--; if(--q->ref)
if(q->ref > 0)
return; return;
qfreecnt++; qfreecnt++;
h = qidhash(q->path); h = qidhash(q->path);