From 404c901f299c4d93cb159a3c44c2977a25408319 Mon Sep 17 00:00:00 2001 From: Alex Musolino Date: Tue, 15 Dec 2020 20:45:26 +1030 Subject: [PATCH] ico: avoid potential nil pointer dereferences Bgeticon can fail, leaving the Icon img pointers nil. --- sys/src/cmd/jpg/ico.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/src/cmd/jpg/ico.c b/sys/src/cmd/jpg/ico.c index 7fb270ed3..f8f9c92ff 100644 --- a/sys/src/cmd/jpg/ico.c +++ b/sys/src/cmd/jpg/ico.c @@ -535,6 +535,8 @@ eresized(int new) r.max.x = screen->r.min.x; r.min.y = screen->r.min.y + font->height + 2*BORDER; for(icon = h.first; icon != nil; icon = icon->next){ + if(icon->img == nil) + continue; r.min.x = r.max.x + BORDER; r.max.x = r.min.x + Dx(icon->img->r); r.max.y = r.min.y + Dy(icon->img->r);