From 0ded533dbc343053b7629bb1c59e74ef3f474526 Mon Sep 17 00:00:00 2001 From: Simon Arlott Date: Sat, 29 Jul 2017 19:25:11 +0100 Subject: [PATCH] ircd: sendto_one_prefix: avoid clang static analysis warning target_p->from can't be NULL, and if it is then get_id(..., target_p) dereferences it later in the function anyway --- ircd/send.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/ircd/send.c b/ircd/send.c index 25a99c71..d8734d6f 100644 --- a/ircd/send.c +++ b/ircd/send.c @@ -312,16 +312,10 @@ void sendto_one_prefix(struct Client *target_p, struct Client *source_p, const char *command, const char *pattern, ...) { - struct Client *dest_p; + struct Client *dest_p = target_p->from; va_list args; buf_head_t linebuf; - /* send remote if to->from non NULL */ - if(target_p->from != NULL) - dest_p = target_p->from; - else - dest_p = target_p; - if(IsIOError(dest_p)) return;