uf0h f9de6763d3 Use playerNeverOnServer message where appropriate (#3489) ... ### Use `playerNeverOnServer` message where it should be used: ### 309e1c470d `playerNeverOnServer=\u00a74Player\u00a7c {0} \u00a74was never on this server.` is currently used in the **Commandmail** class at [Line 61](https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/commands/Commandmail.java#L61), [Line 116](https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/commands/Commandmail.java#L116) and [Line 129](https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/commands/Commandmail.java#L129) however is **not called** as PlayerNotFoundException is thrown by `#getPlayer` breaking current execution (below). ``` Commandmail#run() throws Exception { ... User u = getPlayer(server, args[1], true, true); // throws PlayerNotFoundException if (u == null) { throw new Exception(tl("playerNeverOnServer", args[1])); } ... } ``` Before changes:  After changes:  -------------------------- **Commandseen** currently throws the default PlayerNotFoundException `playerNotFound` message for players that have not logged on to the server where it would be more appropriate to use the `playerNeverOnServer` message. ``` Commandseen#run throws Exception { ... AsyncRunnable#run() { User userFromBukkit = ess.getUserMap().getUserFromBukkit(args[0]); <-- *** try { if (userFromBukkit != null) { <--- *** showUserSeen(userFromBukkit); } else { showUserSeen(getPlayer(server, sender, args, 0)); <--- *** } } catch (Exception e) { ess.showError(sender, e, commandLabel); } } private void showUserSeen(User user) throws Exception { if (user == null) { <--- *** throw new PlayerNotFoundException(); } showSeenMessage(server, sender, user, showBan, showIp, showLocation); } ... } ``` **`<-- ***`:** `usersFromBukkit` null check is performed before `#showUserSeen` so there is no need for another null check. `EssentialsCommand#getPlayer` throws **NotEnoughArguementsException** or **PlayerNotFoundException** after [arg checks](https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/commands/EssentialsCommand.java#L88) and [player checks](https://github.com/EssentialsX/Essentials/blob/2.x/Essentials/src/com/earth2me/essentials/commands/EssentialsCommand.java#L103). https://github.com/EssentialsX/Essentials/pull/3489#issuecomment-657138524 Before changes:  After changes:  ---------------- ### 725128e Catch more specfic exception `PlayerNotFoundException`. Before changes:  After changes: 		2020-08-04 15:30:05 +01:00
..
src	Use playerNeverOnServer message where appropriate (#3489)	2020-08-04 15:30:05 +01:00
test/com/earth2me/essentials	Add sign text tab completion in editsign command (#3497)	2020-07-28 13:12:07 -07:00
pom.xml	Release 2.18.0	2020-07-09 20:15:30 +01:00