mirror of
https://github.com/TotalFreedomMC/TF-EssentialsX.git
synced 2024-06-28 08:50:57 +00:00
9e2b906048
There is an age old issue in Essentials which causes date diffs (such as those displayed in teleportation delays, mutes, and temp bans) to display incorrectly to the user when the command is run. After looking into this a bit, it looks like the reason for this is that if there is even a 1 ms time difference between parsing the date diff and displaying it, the time displayed will be truncated by an entire second. This PR fixes this problem by adding 50 ms of buffer time to the date object *only* when it is calculating the date diff string. This is not significant enough to be noticed by users, and allows Essentials code to correctly generate the date diff string as long as it does so within 50 ms of parsing it. As a theoretical example... lets say a user is muted for 1 year. If 1 ms passed (in code prior to this PR) between parsing and displaying the date diff, then the displayed time will be 11 months, 29 days, 23 hours. This is because 1 year - 1 ms is being truncated down and then Essentials lops off time accuracy beyond the 3 most significant terms. After this PR, the date diff will be parsed normally, but when the display string is being calculated, it will use 1 year + 50 ms (and if 1 ms passed, then that would be 1 year + 49 ms), which gets truncated to 1 year. As a practical example: https://user-images.githubusercontent.com/17698576/82106444-d55c0700-96d5-11ea-8290-377442e4f9fe.png Quite often (I'd say about half of the time) before this PR, the date diff will display like this, when the example command `/mute <player> 1y` is run. https://user-images.githubusercontent.com/17698576/82106467-063c3c00-96d6-11ea-9da2-3dc1556add14.png After this PR, the date diff displays correctly every time. Fixes #3349. |
||
|---|---|---|
| .. | ||
| api | ||
| commands | ||
| craftbukkit | ||
| items | ||
| messaging | ||
| metrics | ||
| perm | ||
| register/payment | ||
| settings | ||
| signs | ||
| storage | ||
| textreader | ||
| utils | ||
| AlternativeCommandsHandler.java | ||
| Backup.java | ||
| ChargeException.java | ||
| CommandSource.java | ||
| Console.java | ||
| Enchantments.java | ||
| Essentials.java | ||
| EssentialsBlockListener.java | ||
| EssentialsConf.java | ||
| EssentialsEntityListener.java | ||
| EssentialsPlayerListener.java | ||
| EssentialsPluginListener.java | ||
| EssentialsServerListener.java | ||
| EssentialsTimer.java | ||
| EssentialsUpgrade.java | ||
| EssentialsUserConf.java | ||
| ExecuteTimer.java | ||
| I18n.java | ||
| IConf.java | ||
| IEssentials.java | ||
| IEssentialsModule.java | ||
| ISettings.java | ||
| ITarget.java | ||
| IUser.java | ||
| Jails.java | ||
| Kit.java | ||
| Kits.java | ||
| LocationTarget.java | ||
| ManagedFile.java | ||
| MetaItemStack.java | ||
| Mob.java | ||
| MobCompat.java | ||
| MobData.java | ||
| OfflinePlayer.java | ||
| PlayerExtension.java | ||
| PlayerList.java | ||
| PlayerTarget.java | ||
| Potions.java | ||
| Settings.java | ||
| SpawnMob.java | ||
| Teleport.java | ||
| TimedTeleport.java | ||
| TNTExplodeListener.java | ||
| Trade.java | ||
| User.java | ||
| UserData.java | ||
| UserMap.java | ||
| UUIDMap.java | ||
| Warps.java | ||
| Worth.java | ||
