mirror of
https://github.com/TotalFreedomMC/TF-EssentialsX.git
synced 2024-06-30 17:59:43 +00:00
d9bf099c3d
This PR reduces the number of sync loads occurring on any teleport caused by essentials. Fixes #2861 Fixes #2287 Fixes #3274 Fixes #3201 Fixes #2120 Before this PR, essentials would get a block multiple times causing sync loads to check if it was safe to teleport to. Now, the target block's chunk if fetched async with PaperLib and passed along to `LocationUtil#isBlockUnsafeForUser` (which internally calls other LocationUtil methods what that chunk object) resulting in the chunk only loading once, off the main thread. The only operations remaining on the main thread is `LocationUtil#getSafeDestination`. This is due to the method's recursion which would be a pain to move async. **However:** since the chunk was already loaded async, `LocationUtil#getSafeDestination` most of the time won't cause sync chunk loads. The only time it would cause sync chunk loads is with an unsafe location near a chunk border. ----------------------------------------- * Reduce sync teleporting loads * Avoid argument re-assigning * Remove async teleports when unnecessary * Make exceptions cleaner * Async all the things Made an async version of every method with fallbacks for deprecated methods. * Remove old now fallback method * Migrate everything to the new async teleport API * Update ITeleport javadocs * Fix invoking via async context * Fix /jail using deprecated method * Fix jail join handler using deprecated method * Rename all teleport classes to indicate async * Remove deprecated methods * Add (and deprecate) old teleport api * Revert TimedTeleport.java * Reduce Diff * Add legacy sendToJail method * Reduce Diff Further * Use getNewExceptionFuture in Commandtpo * Use getNewExceptionFuture everywhere * Fix even more usages * Revert LocationUtil.java * Fix issue causing unsafe locations to not work properly * Add deprecated notice in IUser implementation * Use CompletableFuture#completeExceptionally for exceptions * Use Essentials' logger in EssentialsCommand#showError * Return implementation rather than interface * Avoid possible deadlocks with entity ejections * Nuke some sync loads with homes Took 7 hours and 2 PRs to paper but it's here! * Fix ABI and make the codestyle worse * Make the codestyle worse because muh diff * Further ruin the codestyle * Fix error messages not showing in TimedTeleports * Improve messages around beds for /home * Fix #3274 Allow unsafe locations for different worlds + spectator mode * Fix fly safety operators |
||
|---|---|---|
| .. | ||
| EssentialsSign.java | ||
| SignBalance.java | ||
| SignBlockListener.java | ||
| SignBuy.java | ||
| SignDisposal.java | ||
| SignEnchant.java | ||
| SignEntityListener.java | ||
| SignException.java | ||
| SignFree.java | ||
| SignGameMode.java | ||
| SignHeal.java | ||
| SignInfo.java | ||
| SignKit.java | ||
| SignMail.java | ||
| SignPlayerListener.java | ||
| SignProtection.java | ||
| SignRepair.java | ||
| Signs.java | ||
| SignSell.java | ||
| SignSpawnmob.java | ||
| SignTime.java | ||
| SignTrade.java | ||
| SignWarp.java | ||
| SignWeather.java | ||