TotalFreedomMC/TF-EssentialsX
1
0
Fork 0
mirror of https://github.com/TotalFreedomMC/TF-EssentialsX.git synced 2025-08-03 11:06:08 +00:00
Code Issues Projects Releases Wiki Activity

Catch NullPointerExceptions in SLPE (#1463)

Browse source 
* Catch NullPointerExceptions in SLPE
* Use the caught NPE's stacktrace
    Makes thrown exception actually useful
This commit is contained in:
md678685 2017-08-21 10:40:23 +01:00 • committed by GitHub
parent 365ae356bd
commit a049a03faa
1 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Essentials/src/com/earth2me/essentials/EssentialsServerListener.java
View file

@ -17,7 +17,8 @@ import java.util.logging.Level;
public class EssentialsServerListener implements Listener { public class EssentialsServerListener implements Listener {
private final transient IEssentials ess; private final transient IEssentials ess;
private boolean errorLogged = false; private boolean unsupportedLogged = false;
private boolean npeWarned = false;
private boolean isPaperSample; private boolean isPaperSample;
private Method setSampleText; private Method setSampleText;
private Method getSampleText; private Method getSampleText;
@ -36,7 +37,7 @@ public class EssentialsServerListener implements Listener {
} }
@EventHandler(priority = EventPriority.LOWEST) @EventHandler(priority = EventPriority.LOWEST)
public void onServerListPing(final ServerListPingEvent event) { public void onServerListPing(final ServerListPingEvent event) throws Exception {
if (isPaperSample) { if (isPaperSample) {
try { try {
List<String> playerNames = (List<String>) getSampleText.invoke(event, null); List<String> playerNames = (List<String>) getSampleText.invoke(event, null);
@ -49,9 +50,18 @@ public class EssentialsServerListener implements Listener {
} }
setSampleText.invoke(event, playerNames); setSampleText.invoke(event, playerNames);
} catch (IllegalAccessException | InvocationTargetException | ClassCastException e) { } catch (IllegalAccessException | InvocationTargetException | ClassCastException e) {
if (!errorLogged) { if (!unsupportedLogged) {
ess.getLogger().log(Level.WARNING, "Unable to hide players from server list ping using Paper 1.12+ method!", e); ess.getLogger().log(Level.WARNING, "Unable to hide players from server list ping "
errorLogged = true; + "using Paper 1.12+ method!", e);
unsupportedLogged = true;
}
} catch (NullPointerException e) {
if (!npeWarned) {
npeWarned = true;
Exception ex = new Exception("A plugin has fired a ServerListPingEvent "
+ "without implementing Paper's methods. Point the author to https://git.io/v7Xzl.");
ex.setStackTrace(e.getStackTrace());
throw ex;
} }
} }
} else { } else {
@ -64,10 +74,10 @@ public class EssentialsServerListener implements Listener {
} }
} }
} catch (UnsupportedOperationException e) { } catch (UnsupportedOperationException e) {
if (!errorLogged) { if (!unsupportedLogged) {
ess.getLogger().warning("Current server implementation does not support " ess.getLogger().warning("Current server implementation does not support "
+ "hiding players from server list ping. Update or contact the maintainers."); + "hiding players from server list ping. Update or contact the maintainers.");
errorLogged = true; unsupportedLogged = true;
} }
} }
} }