TotalFreedomMC/TF-EssentialsX
1
0
Fork 0
mirror of https://github.com/TotalFreedomMC/TF-EssentialsX.git synced 2025-02-12 04:20:41 +00:00
Code Issues Projects Releases Wiki Activity

Optimize sorting to speedup permission tests.

Browse source
This commit is contained in:
ElgarL 2011-11-24 13:26:30 +00:00
parent fd1c2824ce
commit 94983c3ca7
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
EssentialsGroupManager/src/Changelog.txt
View file

@ -76,3 +76,4 @@ v 1.5:
v 1.6: v 1.6:
- Prevent Group.equals tests throwing a NullPointerException for GlobalGroups. - Prevent Group.equals tests throwing a NullPointerException for GlobalGroups.
- Stop throwing errors on an empty users file. - Stop throwing errors on an empty users file.
- Optimize sorting to speedup permission tests.

10
EssentialsGroupManager/src/org/anjocaido/groupmanager/data/DataUnit.java
View file

@ -18,7 +18,7 @@ public abstract class DataUnit {
private WorldDataHolder dataSource; private WorldDataHolder dataSource;
private String name; private String name;
private boolean changed; private boolean changed, sorted = false;
private ArrayList<String> permissions = new ArrayList<String>(); private ArrayList<String> permissions = new ArrayList<String>();
public DataUnit(WorldDataHolder dataSource, String name) { public DataUnit(WorldDataHolder dataSource, String name) {
@ -91,6 +91,7 @@ public abstract class DataUnit {
// for(StackTraceElement st: Thread.currentThread().getStackTrace()){ // for(StackTraceElement st: Thread.currentThread().getStackTrace()){
// GroupManager.logger.finest(st.toString()); // GroupManager.logger.finest(st.toString());
// } // }
sorted = false;
changed = true; changed = true;
} }
@ -136,7 +137,14 @@ public abstract class DataUnit {
return new ArrayList<String>(permissions); return new ArrayList<String>(permissions);
} }
public boolean isSorted() {
return this.sorted;
}
public void sortPermissions() { public void sortPermissions() {
if (!isSorted()) {
Collections.sort(permissions, StringPermissionComparator.getInstance()); Collections.sort(permissions, StringPermissionComparator.getInstance());
sorted = true;
}
} }
} }