Optimize sorting to speedup permission tests.

This commit is contained in:
ElgarL 2011-11-24 13:26:30 +00:00
parent fd1c2824ce
commit 94983c3ca7
2 changed files with 12 additions and 3 deletions

View file

@ -75,4 +75,5 @@ v 1.5:
- Fixed a crash on reload due to bukkit not unloading plugins before reloading.
v 1.6:
- Prevent Group.equals tests throwing a NullPointerException for GlobalGroups.
- Stop throwing errors on an empty users file.
- Stop throwing errors on an empty users file.
- Optimize sorting to speedup permission tests.

View file

@ -18,7 +18,7 @@ public abstract class DataUnit {
private WorldDataHolder dataSource;
private String name;
private boolean changed;
private boolean changed, sorted = false;
private ArrayList<String> permissions = new ArrayList<String>();
public DataUnit(WorldDataHolder dataSource, String name) {
@ -91,6 +91,7 @@ public abstract class DataUnit {
// for(StackTraceElement st: Thread.currentThread().getStackTrace()){
// GroupManager.logger.finest(st.toString());
// }
sorted = false;
changed = true;
}
@ -135,8 +136,15 @@ public abstract class DataUnit {
public ArrayList<String> getPermissionList() {
return new ArrayList<String>(permissions);
}
public boolean isSorted() {
return this.sorted;
}
public void sortPermissions() {
Collections.sort(permissions, StringPermissionComparator.getInstance());
if (!isSorted()) {
Collections.sort(permissions, StringPermissionComparator.getInstance());
sorted = true;
}
}
}