TotalFreedomMC/TF-EssentialsX
1
0
Fork 0
mirror of https://github.com/TotalFreedomMC/TF-EssentialsX.git synced 2024-07-02 10:43:51 +00:00
Code Issues Projects Releases Wiki Activity

Improve VersionUtil prerelease handling

Browse source 
Actually includes updated regex this time! (I have no idea how I forgot to update it in cfba203981 - I had already written out the regex)

Incorporates part of https://github.com/EssentialsX/Essentials/pull/2523 - thanks @JRoy.
This commit is contained in:
md678685 2019-05-08 23:26:40 +01:00
parent 4fcb032791
commit 6d4f7afc79
2 changed files with 14 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Essentials/src/com/earth2me/essentials/utils/VersionUtil.java
View file

@ -20,10 +20,9 @@ public class VersionUtil {
public static final BukkitVersion v1_12_2_R01 = BukkitVersion.fromString("1.12.2-R0.1-SNAPSHOT"); public static final BukkitVersion v1_12_2_R01 = BukkitVersion.fromString("1.12.2-R0.1-SNAPSHOT");
public static final BukkitVersion v1_13_0_R01 = BukkitVersion.fromString("1.13.0-R0.1-SNAPSHOT"); public static final BukkitVersion v1_13_0_R01 = BukkitVersion.fromString("1.13.0-R0.1-SNAPSHOT");
public static final BukkitVersion v1_13_2_R01 = BukkitVersion.fromString("1.13.2-R0.1-SNAPSHOT"); public static final BukkitVersion v1_13_2_R01 = BukkitVersion.fromString("1.13.2-R0.1-SNAPSHOT");
// TODO: update to 1.14 release public static final BukkitVersion v1_14_R01 = BukkitVersion.fromString("1.14-R0.1-SNAPSHOT");
public static final BukkitVersion v1_14_PRE5 = BukkitVersion.fromString("1.14-pre5-SNAPSHOT");
private static final Set<BukkitVersion> supportedVersions = ImmutableSet.of(v1_8_8_R01, v1_9_4_R01, v1_10_2_R01, v1_11_2_R01, v1_12_2_R01, v1_13_2_R01); private static final Set<BukkitVersion> supportedVersions = ImmutableSet.of(v1_8_8_R01, v1_9_4_R01, v1_10_2_R01, v1_11_2_R01, v1_12_2_R01, v1_13_2_R01, v1_14_R01);
private static BukkitVersion serverVersion = null; private static BukkitVersion serverVersion = null;
@ -39,7 +38,7 @@ public class VersionUtil {
} }
public static class BukkitVersion implements Comparable<BukkitVersion> { public static class BukkitVersion implements Comparable<BukkitVersion> {
private static final Pattern VERSION_PATTERN = Pattern.compile("^(\\d+)\\.(\\d+)\\.?([0-9]*)-R([\\d.]+)(?:-SNAPSHOT)?"); private static final Pattern VERSION_PATTERN = Pattern.compile("^(\\d+)\\.(\\d+)\\.?([0-9]*)?-(?:pre(\\d))?-?R?([\\d.]+)?(?:-SNAPSHOT)?");
private final int major; private final int major;
private final int minor; private final int minor;
@ -54,17 +53,17 @@ public class VersionUtil {
if (!Bukkit.getName().equals("Essentials Fake Server")) { if (!Bukkit.getName().equals("Essentials Fake Server")) {
throw new IllegalArgumentException(string + " is not in valid version format. e.g. 1.8.8-R0.1"); throw new IllegalArgumentException(string + " is not in valid version format. e.g. 1.8.8-R0.1");
} }
matcher = VERSION_PATTERN.matcher(v1_13_2_R01.toString()); matcher = VERSION_PATTERN.matcher(v1_14_R01.toString());
Preconditions.checkArgument(matcher.matches(), string + " is not in valid version format. e.g. 1.8.8-R0.1"); Preconditions.checkArgument(matcher.matches(), string + " is not in valid version format. e.g. 1.8.8-R0.1");
} }
return from(matcher.group(1), matcher.group(2), matcher.group(3), matcher.group(4), matcher.group(5)); return from(matcher.group(1), matcher.group(2), matcher.group(3), matcher.groupCount() < 5 ? "" : matcher.group(5), matcher.group(4));
} }
private static BukkitVersion from(String major, String minor, String patch, String revision, String prerelease) { private static BukkitVersion from(String major, String minor, String patch, String revision, String prerelease) {
if (patch.isEmpty()) patch = "0"; if (patch == null || patch.isEmpty()) patch = "0";
if (revision.isEmpty()) revision = "0"; if (revision == null || revision.isEmpty()) revision = "0";
if (prerelease.isEmpty()) prerelease = "-1"; if (prerelease == null || prerelease.isEmpty()) prerelease = "-1";
return new BukkitVersion(Integer.parseInt(major), return new BukkitVersion(Integer.parseInt(major),
Integer.parseInt(minor), Integer.parseInt(minor),
Integer.parseInt(patch), Integer.parseInt(patch),

2
Essentials/test/com/earth2me/essentials/UtilTest.java
View file

@ -208,7 +208,7 @@ public class UtilTest extends TestCase {
assertEquals(v.getMajor(), 1); assertEquals(v.getMajor(), 1);
assertEquals(v.getMinor(), 14); assertEquals(v.getMinor(), 14);
assertEquals(v.getPatch(), 0); assertEquals(v.getPatch(), 0);
assertEquals(v.getRevision(), 0); assertEquals(v.getRevision(), 0.0);
assertEquals(v.getPrerelease(), 5); assertEquals(v.getPrerelease(), 5);
v = VersionUtil.BukkitVersion.fromString("1.13.2-pre1-R0.1"); // not real v = VersionUtil.BukkitVersion.fromString("1.13.2-pre1-R0.1"); // not real
assertEquals(v.getMajor(), 1); assertEquals(v.getMajor(), 1);