From 2c33fb683439fd4353fab9d660c62f26150dd068 Mon Sep 17 00:00:00 2001
From: md678685 <1917406+md678685@users.noreply.github.com>
Date: Tue, 13 Aug 2019 15:11:43 +0100
Subject: [PATCH] Correctly return null for invalid IDs when doing legacy
 conversion

---
 Essentials/src/com/earth2me/essentials/api/IItemDb.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Essentials/src/com/earth2me/essentials/api/IItemDb.java b/Essentials/src/com/earth2me/essentials/api/IItemDb.java
index 7df534ec8..2c066d0c0 100644
--- a/Essentials/src/com/earth2me/essentials/api/IItemDb.java
+++ b/Essentials/src/com/earth2me/essentials/api/IItemDb.java
@@ -130,11 +130,13 @@ public interface IItemDb {
      * item IDs to modern names.
      *
      * @param item Legacy ID in colon syntax.
-     * @return
+     * @return Material if an appropriate material exists, else null.
      */
     default Material getFromLegacy(String item) {
         final String[] split = item.split(":");
 
+        if (!NumberUtil.isInt(split[0])) return null;
+
         final int id = Integer.parseInt(split[0]);
         byte damage = 0;