From 1c4ce7b4bd112423d39d4b68855787c9a6d52fbe Mon Sep 17 00:00:00 2001
From: md678685 <1917406+md678685@users.noreply.github.com>
Date: Thu, 26 Dec 2019 13:08:38 +0000
Subject: [PATCH] Don't assume primary group is always present

Fixes a potential issue with PEX 2.0 (and 1.x) where users may not have a primary group.
Closes #2901.
---
 .../perm/impl/AbstractVaultHandler.java       | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/Essentials/src/com/earth2me/essentials/perm/impl/AbstractVaultHandler.java b/Essentials/src/com/earth2me/essentials/perm/impl/AbstractVaultHandler.java
index b2d381cdf..b10864400 100644
--- a/Essentials/src/com/earth2me/essentials/perm/impl/AbstractVaultHandler.java
+++ b/Essentials/src/com/earth2me/essentials/perm/impl/AbstractVaultHandler.java
@@ -46,23 +46,31 @@ public abstract class AbstractVaultHandler extends SuperpermsHandler {
     @Override
     public String getPrefix(final Player base) {
         String playerPrefix = chat.getPlayerPrefix(base);
-        if (playerPrefix == null) {
-            String playerGroup = perms.getPrimaryGroup(base);
-            return chat.getGroupPrefix(base.getWorld().getName(), playerGroup);
-        } else {
+        if (playerPrefix != null) {
             return playerPrefix;
         }
+
+        String playerGroup = perms.getPrimaryGroup(base);
+        if (playerGroup != null) {
+            return chat.getGroupPrefix(base.getWorld().getName(), playerGroup);
+        }
+
+        return null;
     }
 
     @Override
     public String getSuffix(final Player base) {
         String playerSuffix = chat.getPlayerSuffix(base);
-        if (playerSuffix == null) {
-            String playerGroup = perms.getPrimaryGroup(base);
-            return chat.getGroupSuffix(base.getWorld().getName(), playerGroup);
-        } else {
+        if (playerSuffix != null) {
             return playerSuffix;
         }
+
+        String playerGroup = perms.getPrimaryGroup(base);
+        if (playerGroup != null) {
+            return chat.getGroupSuffix(base.getWorld().getName(), playerGroup);
+        }
+
+        return null;
     }
 
     boolean canLoad() {