TotalFreedomMC/PlayerParticles
1
0
Fork 0
mirror of https://github.com/TotalFreedomMC/PlayerParticles.git synced 2025-07-04 04:51:26 +00:00
Code Issues Projects Releases Wiki Activity

Performance improvement by caching PPlayer Player reference

Browse source
This commit is contained in:
Esophose 2020-02-13 17:32:40 -07:00
parent 1c834c7bb6
commit c2146c11b9
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/main/java/dev/esophose/playerparticles/manager/ParticleManager.java
View file

@ -97,9 +97,12 @@ public class ParticleManager extends Manager implements Listener, Runnable {
@EventHandler(priority = EventPriority.MONITOR) @EventHandler(priority = EventPriority.MONITOR)
public void onPlayerQuit(PlayerQuitEvent e) { public void onPlayerQuit(PlayerQuitEvent e) {
PPlayer pplayer = this.playerParticles.getManager(DataManager.class).getPPlayer(e.getPlayer().getUniqueId()); PPlayer pplayer = this.playerParticles.getManager(DataManager.class).getPPlayer(e.getPlayer().getUniqueId());
if (pplayer != null && pplayer.getFixedEffectIds().isEmpty()) if (pplayer != null) {
pplayer.clearCachedPlayer();
if (pplayer.getFixedEffectIds().isEmpty())
this.particlePlayers.remove(pplayer.getUniqueId()); // Unload the PPlayer if they don't have any fixed effects this.particlePlayers.remove(pplayer.getUniqueId()); // Unload the PPlayer if they don't have any fixed effects
} }
}
/** /**
* Gets the PPlayers that are loaded * Gets the PPlayers that are loaded

16
src/main/java/dev/esophose/playerparticles/particles/PPlayer.java
View file

@ -18,6 +18,11 @@ public class PPlayer {
*/ */
private final UUID playerUUID; private final UUID playerUUID;
/**
* Cached instance of the player
*/
private Player cachedPlayer;
/** /**
* A map of ParticleGroups this player has, the active particle group has an id of null * A map of ParticleGroups this player has, the active particle group has an id of null
*/ */
@ -74,7 +79,16 @@ public class PPlayer {
* @return the underlying CommandSender who executed the command * @return the underlying CommandSender who executed the command
*/ */
public Player getPlayer() { public Player getPlayer() {
return Bukkit.getPlayer(this.playerUUID); if (this.cachedPlayer == null)
this.cachedPlayer = Bukkit.getPlayer(this.playerUUID);
return this.cachedPlayer;
}
/**
* Clears the cached player to prevent the reference from lingering
*/
public void clearCachedPlayer() {
this.cachedPlayer = null;
} }
/** /**