From 0826bbf31cd0d95f639aaaaa24907063dfd49335 Mon Sep 17 00:00:00 2001 From: Esophose Date: Sat, 1 Feb 2020 18:38:12 -0700 Subject: [PATCH] Throw exceptions when registering invalid styles --- .../manager/ParticleStyleManager.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/main/java/dev/esophose/playerparticles/manager/ParticleStyleManager.java b/src/main/java/dev/esophose/playerparticles/manager/ParticleStyleManager.java index 1408b5e..5c3b16e 100644 --- a/src/main/java/dev/esophose/playerparticles/manager/ParticleStyleManager.java +++ b/src/main/java/dev/esophose/playerparticles/manager/ParticleStyleManager.java @@ -40,22 +40,18 @@ public class ParticleStyleManager extends Manager { */ public void registerStyle(ParticleStyle style) { if (style == null) { - PlayerParticles.getInstance().getLogger().severe("Tried to register a null style"); - return; + throw new IllegalArgumentException("Tried to register a null style"); } if (style.getInternalName() == null || style.getInternalName().trim().equals("")) { - PlayerParticles.getInstance().getLogger().severe("Tried to register a style with a null or empty name: '" + style.getInternalName() + "'"); - return; + throw new IllegalArgumentException("Tried to register a style with a null or empty name: '" + style.getInternalName() + "'"); } for (ParticleStyle testAgainst : this.styles) { if (testAgainst.equals(style)) { - PlayerParticles.getInstance().getLogger().severe("Tried to register the same style twice: '" + style.getInternalName() + "'"); - return; + throw new IllegalArgumentException("Tried to register the same style twice: '" + style.getInternalName() + "'"); } else if (testAgainst.getInternalName().equalsIgnoreCase(style.getInternalName())) { - PlayerParticles.getInstance().getLogger().severe("Tried to register two styles with the same internal name spelling: '" + style.getInternalName() + "'"); - return; + throw new IllegalArgumentException("Tried to register two styles with the same internal name spelling: '" + style.getInternalName() + "'"); } }