reactos/dll/win32/shell32/CShellItem.cpp
Giannis Adamopoulos 3263303844 [SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.
2018-02-20 16:59:00 +02:00

337 lines
8.3 KiB
C++

/*
* IShellItem implementation
*
* Copyright 2008 Vincent Povirk for CodeWeavers
* Copyright 2009 Andrew Hill
* Copyright 2013 Katayama Hirofumi MZ
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include "precomp.h"
WINE_DEFAULT_DEBUG_CHANNEL(shell);
EXTERN_C HRESULT WINAPI SHCreateShellItem(LPCITEMIDLIST pidlParent,
IShellFolder *psfParent, LPCITEMIDLIST pidl, IShellItem **ppsi);
CShellItem::CShellItem() :
m_pidl(NULL)
{
}
CShellItem::~CShellItem()
{
ILFree(m_pidl);
}
HRESULT CShellItem::get_parent_pidl(LPITEMIDLIST *parent_pidl)
{
*parent_pidl = ILClone(m_pidl);
if (*parent_pidl)
{
if (ILRemoveLastID(*parent_pidl))
return S_OK;
else
{
ILFree(*parent_pidl);
*parent_pidl = NULL;
return E_INVALIDARG;
}
}
else
{
*parent_pidl = NULL;
return E_OUTOFMEMORY;
}
}
HRESULT CShellItem::get_parent_shellfolder(IShellFolder **ppsf)
{
HRESULT hr;
LPITEMIDLIST parent_pidl;
CComPtr<IShellFolder> desktop;
hr = get_parent_pidl(&parent_pidl);
if (SUCCEEDED(hr))
{
hr = SHGetDesktopFolder(&desktop);
if (SUCCEEDED(hr))
hr = desktop->BindToObject(parent_pidl, NULL, IID_PPV_ARG(IShellFolder, ppsf));
ILFree(parent_pidl);
}
return hr;
}
HRESULT CShellItem::get_shellfolder(IBindCtx *pbc, REFIID riid, void **ppvOut)
{
CComPtr<IShellFolder> psf;
CComPtr<IShellFolder> psfDesktop;
HRESULT ret;
ret = SHGetDesktopFolder(&psfDesktop);
if (FAILED_UNEXPECTEDLY(ret))
return ret;
if (_ILIsDesktop(m_pidl))
psf = psfDesktop;
else
{
ret = psfDesktop->BindToObject(m_pidl, pbc, IID_PPV_ARG(IShellFolder, &psf));
if (FAILED_UNEXPECTEDLY(ret))
return ret;
}
return psf->QueryInterface(riid, ppvOut);
}
HRESULT WINAPI CShellItem::BindToHandler(IBindCtx *pbc, REFGUID rbhid, REFIID riid, void **ppvOut)
{
HRESULT ret;
TRACE("(%p, %p,%s,%p,%p)\n", this, pbc, shdebugstr_guid(&rbhid), riid, ppvOut);
*ppvOut = NULL;
if (IsEqualGUID(rbhid, BHID_SFObject))
{
return get_shellfolder(pbc, riid, ppvOut);
}
else if (IsEqualGUID(rbhid, BHID_SFUIObject))
{
CComPtr<IShellFolder> psf_parent;
if (_ILIsDesktop(m_pidl))
ret = SHGetDesktopFolder(&psf_parent);
else
ret = get_parent_shellfolder(&psf_parent);
if (FAILED_UNEXPECTEDLY(ret))
return ret;
LPCITEMIDLIST pidl = ILFindLastID(m_pidl);
return psf_parent->GetUIObjectOf(NULL, 1, &pidl, riid, NULL, ppvOut);
}
else if (IsEqualGUID(rbhid, BHID_DataObject))
{
return BindToHandler(pbc, BHID_SFUIObject, IID_IDataObject, ppvOut);
}
else if (IsEqualGUID(rbhid, BHID_SFViewObject))
{
CComPtr<IShellFolder> psf;
ret = get_shellfolder(NULL, IID_PPV_ARG(IShellFolder, &psf));
if (FAILED_UNEXPECTEDLY(ret))
return ret;
return psf->CreateViewObject(NULL, riid, ppvOut);
}
FIXME("Unsupported BHID %s.\n", debugstr_guid(&rbhid));
return MK_E_NOOBJECT;
}
HRESULT WINAPI CShellItem::GetParent(IShellItem **ppsi)
{
HRESULT hr;
LPITEMIDLIST parent_pidl;
TRACE("(%p,%p)\n", this, ppsi);
hr = get_parent_pidl(&parent_pidl);
if (SUCCEEDED(hr))
{
hr = SHCreateShellItem(NULL, NULL, parent_pidl, ppsi);
ILFree(parent_pidl);
}
return hr;
}
HRESULT WINAPI CShellItem::GetDisplayName(SIGDN sigdnName, LPWSTR *ppszName)
{
return SHGetNameFromIDList(m_pidl, sigdnName, ppszName);
}
HRESULT WINAPI CShellItem::GetAttributes(SFGAOF sfgaoMask, SFGAOF *psfgaoAttribs)
{
CComPtr<IShellFolder> parent_folder;
LPCITEMIDLIST child_pidl;
HRESULT hr;
TRACE("(%p,%x,%p)\n", this, sfgaoMask, psfgaoAttribs);
if (_ILIsDesktop(m_pidl))
hr = SHGetDesktopFolder(&parent_folder);
else
hr = get_parent_shellfolder(&parent_folder);
if (FAILED_UNEXPECTEDLY(hr))
return hr;
child_pidl = ILFindLastID(m_pidl);
*psfgaoAttribs = sfgaoMask;
hr = parent_folder->GetAttributesOf(1, &child_pidl, psfgaoAttribs);
*psfgaoAttribs &= sfgaoMask;
if (FAILED_UNEXPECTEDLY(hr))
return hr;
return (sfgaoMask == *psfgaoAttribs) ? S_OK : S_FALSE;
}
HRESULT WINAPI CShellItem::Compare(IShellItem *oth, SICHINTF hint, int *piOrder)
{
HRESULT hr;
CComPtr<IPersistIDList> pIDList;
CComPtr<IShellFolder> psfDesktop;
LPITEMIDLIST pidl;
TRACE("(%p,%p,%x,%p)\n", this, oth, hint, piOrder);
if (piOrder == NULL || oth == NULL)
return E_POINTER;
hr = oth->QueryInterface(IID_PPV_ARG(IPersistIDList, &pIDList));
if (SUCCEEDED(hr))
{
hr = pIDList->GetIDList(&pidl);
if (SUCCEEDED(hr))
{
hr = SHGetDesktopFolder(&psfDesktop);
if (SUCCEEDED(hr))
{
hr = psfDesktop->CompareIDs(hint, m_pidl, pidl);
*piOrder = (int)(short)SCODE_CODE(hr);
}
ILFree(pidl);
}
}
if(FAILED(hr))
return hr;
if(*piOrder)
return S_FALSE;
else
return S_OK;
}
HRESULT WINAPI CShellItem::GetClassID(CLSID *pClassID)
{
TRACE("(%p,%p)\n", this, pClassID);
*pClassID = CLSID_ShellItem;
return S_OK;
}
HRESULT WINAPI CShellItem::SetIDList(LPCITEMIDLIST pidlx)
{
LPITEMIDLIST new_pidl;
TRACE("(%p,%p)\n", this, pidlx);
new_pidl = ILClone(pidlx);
if (new_pidl)
{
ILFree(m_pidl);
m_pidl = new_pidl;
return S_OK;
}
else
return E_OUTOFMEMORY;
}
HRESULT WINAPI CShellItem::GetIDList(LPITEMIDLIST *ppidl)
{
TRACE("(%p,%p)\n", this, ppidl);
*ppidl = ILClone(m_pidl);
if (*ppidl)
return S_OK;
else
return E_OUTOFMEMORY;
}
HRESULT WINAPI SHCreateShellItem(LPCITEMIDLIST pidlParent,
IShellFolder *psfParent, LPCITEMIDLIST pidl, IShellItem **ppsi)
{
HRESULT hr;
CComPtr<IShellItem> newShellItem;
LPITEMIDLIST new_pidl;
CComPtr<IPersistIDList> newPersistIDList;
TRACE("(%p,%p,%p,%p)\n", pidlParent, psfParent, pidl, ppsi);
*ppsi = NULL;
if (!pidl)
return E_INVALIDARG;
if (pidlParent || psfParent)
{
LPITEMIDLIST temp_parent = NULL;
if (!pidlParent)
{
CComPtr<IPersistFolder2> ppf2Parent;
if (FAILED(psfParent->QueryInterface(IID_PPV_ARG(IPersistFolder2, &ppf2Parent))))
{
FIXME("couldn't get IPersistFolder2 interface of parent\n");
return E_NOINTERFACE;
}
if (FAILED(ppf2Parent->GetCurFolder(&temp_parent)))
{
FIXME("couldn't get parent PIDL\n");
return E_NOINTERFACE;
}
pidlParent = temp_parent;
}
new_pidl = ILCombine(pidlParent, pidl);
ILFree(temp_parent);
if (!new_pidl)
return E_OUTOFMEMORY;
}
else
{
new_pidl = ILClone(pidl);
if (!new_pidl)
return E_OUTOFMEMORY;
}
hr = CShellItem::_CreatorClass::CreateInstance(NULL, IID_PPV_ARG(IShellItem, &newShellItem));
if (FAILED(hr))
{
ILFree(new_pidl);
return hr;
}
hr = newShellItem->QueryInterface(IID_PPV_ARG(IPersistIDList, &newPersistIDList));
if (FAILED(hr))
{
ILFree(new_pidl);
return hr;
}
hr = newPersistIDList->SetIDList(new_pidl);
if (FAILED(hr))
{
ILFree(new_pidl);
return hr;
}
ILFree(new_pidl);
*ppsi = newShellItem.Detach();
return hr;
}