reactos/base/applications/mspaint
Ștefan Fulea 3d48aa2992 [MSPAINT] Fix scrollbar presence on canvas/view fitting (#878)
* [MSPAINT] Fix scrollbar presence on canvas/view fitting

This is a small fix for a scrollbar related edge case functionality exhibited in mspaint (and in a lesser degree also elsewhere in instances of) scrollbar controlled content. As known, the scrollbars presence is given by the size ratio between the accommodating outer frame and the scroll-controlled contents inside it, and it works for the most part. There is, however, a case where the presence of both toolbars is kept even when the contents would fit the frame (if not for the scrollbars themselves that increase the size of the contents' area). Please take the current commit as a demo fix and a provisional correction for mspaint (as I think that the proper fix should reside in common controls).

* [MSPAINT] Fix a small mistake and improve readability in UpdateScrollbox()

Although with no visible impact on testing, I've used a wrong constant related to vertical scrollbox width in one instance (SM_CXHSCROLL instead of SM_CXVSCROLL), and this fixes it. Also, prefer using constants, to improve a bit readability and performance (by avoiding repeated function calls).
2018-11-16 23:05:51 +01:00
..
help Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
icons [mspaint] Replace the current 16 pixel program icon with one from the Tango icon theme. 2017-11-07 22:53:36 +01:00
lang [TRANSLATIONS] Style fixes for Estonian 2018-11-07 22:10:27 +01:00
CMakeLists.txt Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
common.h [MSPAINT] Fix crash on zoom out 2018-04-23 20:11:43 +02:00
definitions.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
dialogs.cpp [MSPAINT] Base dialog implementations on CDialogImpl 2017-11-02 21:29:40 +01:00
dialogs.h [MSPAINT] Fix copy-pasta bug (#562) 2018-05-23 22:17:22 +02:00
dib.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
dib.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
drawing.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
drawing.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
fullscreen.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
fullscreen.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
globalvar.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
history.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
history.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
imgarea.cpp [MSPAINT] Fix call sequence in OnRButtonUp 2018-05-24 22:12:15 +02:00
imgarea.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
main.cpp [MSPAINT] Fix interpretation of command line (#707) 2018-08-12 11:23:16 +02:00
miniature.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
miniature.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
mouse.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
mouse.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
mspaint.exe.amd64.manifest Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
mspaint.exe.manifest Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
palette.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
palette.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
palettemodel.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
palettemodel.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
precomp.h [MSPAINT] Fix crash on zoom out 2018-04-23 20:11:43 +02:00
registry.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
registry.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
rsrc.rc [MSPAINT] Added Vietnamese translation. (#722) 2018-08-03 12:10:16 +02:00
scrollbox.cpp [MSPAINT] Fix scrollbar presence on canvas/view fitting (#878) 2018-11-16 23:05:51 +01:00
scrollbox.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
selection.cpp [MSPAINT] When clicking selection, invalidate _and_ repaint Scroll Client _and_ Image Area 2018-05-26 14:21:07 +02:00
selection.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
selectionmodel.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
selectionmodel.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
sizebox.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
sizebox.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
textedit.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
textedit.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
toolbox.cpp [REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate. 2018-02-19 22:36:36 +01:00
toolbox.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
toolsettings.cpp [MSPAINT] Fix crash on zoom out 2018-04-23 20:11:43 +02:00
toolsettings.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
toolsmodel.cpp Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00
toolsmodel.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00
winproc.cpp [MSPAINT] Store subsequent changes to file selected via Save As 2018-05-26 14:16:17 +02:00
winproc.h [MSPAINT] Add some header guards. 2017-12-09 13:36:45 +01:00