reactos/dll/win32/advapi32
Timo Kreuzer c5158963a3 [ADVAPI32] Fix a buffer overflow in RegQueryValueExA
The code was trying to check whether the output string was already NULL terminated by RtlUnicodeToMultiByteN before NULL terminating it by checking DataStr[*count - 1] for a NULL terminator. But since RtlUnicodeToMultiByteSize always returns the size without the NULL terminator, DataStr[*count - 1] would always be the last actual character, never an optional NULL terminator.
For 0 sized strings this would actually lead to accessing the output buffer at position -1 (on 32 bit)  or 0xFFFFFFFF (on 64 bit).
Fix this by removing the check. This fixes a crash in advapi32_winetest:registry on x64.
2023-01-04 10:32:28 +01:00
..
misc [ADVAPI32] Implement security descriptor management in CreateProcessAsUserCommon internal function 2022-05-06 10:09:50 +02:00
reg [ADVAPI32] Fix a buffer overflow in RegQueryValueExA 2023-01-04 10:32:28 +01:00
sec [REACTOS] Add '\n' to debug logs 2022-05-04 03:28:38 +03:00
service [REACTOS] Add '\n' to debug logs 2022-05-04 03:28:38 +03:00
token [ADVAPI32] Avoid excessive allocation in CheckTokenMembership. CORE-16094 2019-07-21 11:39:30 +02:00
wine [SECLOGON][ADVAPI] CreateProcessWithLogonW: Return process information to the caller 2022-07-24 01:08:13 +02:00
advapi32.h [ADVAPI32] Remove buggy declaration of SystemFunction034 2022-02-21 17:34:23 +01:00
advapi32.rc
advapi32.spec [REACTOS] *.spec: Fix some function/parameter types (#3154) 2020-09-20 19:21:11 +02:00
CMakeLists.txt [ADVAPI32][SECLOGON] Start the implementation of CreateProcessWithLogonW 2022-02-21 16:38:29 +01:00