reactos/win32ss/user
Joachim Henze e95c6fe661 [0.4.10][SHELL32][USER32] Improve MSVC2010SP1 bootcd icon rendering CORE-14982 and CORE-15150
During 0.4.10-dev' Katayama worked heavily on the icon selection dialog and when
we branched the releases/0.4.10 that was WIP, so we had a pretty inconsistent state unfortunately
regarding extracting the desktop icons. The required fixing took a very long time
into 0.4.11-dev'ing back then.
So my only option for releases/0.4.10 back then was to appease the problems via
0.4.10-RC-13-g 3a1fe9d044
which worked very well and gave a consistent state for the GCC build.

Unfortunately it lead to the MSVC2010SP1 dbg build bootcd to not show some icons on the desktop
and within the whole startmenu. As said: GCC was not affected by that. And LiveCD was neither.

So today I do port back the remaining improvements in this context from 0.4.11-dev'ing to
improve again also for the MSVC2010SP1 builds bootcd of releases/0.4.10:
0.4.11-dev-361-g 2cbac3d049 [SHELL32] CORE-14982
0.4.11-dev-357-g 40737bdddb [USER32] Fix the ICO_ExtractIconExW() helper CORE-15150 <- this part is essential
0.4.11-dev-29-g 19e9a44118 [SHELL32] Check the result from PathUnExpandEnvStringsW

And while touching the file CShellLink.cpp anyway, I took also some other small unrelated improvements with me:
0.4.11-dev-360-g 1e20a3e5b5 [SHELL32] 'Fix a potential buffer overrun' (which is a tiny part of CORE-8545)
0.4.11-dev-256-g ae9ec94240 [SHELL32] Code formatting only (I picked only the CShellLink.cpp changes here)
0.4.11-dev-28-g 608cb60e44 [SHELL32] Remove some mostly dead code from CShellLink
2022-12-04 21:27:39 +01:00
..
ntuser [0.4.10][NTUSER] Fix taskbar panes activation (#2046) (#3294) (#3697) (#3700), [SHELL32] (#4800) 2022-10-22 22:31:23 +02:00
rtl [WIN32SS] Fix DrawText wrt DT_CALCRECT | DT_VCENTER (#745) 2018-08-15 19:50:19 +02:00
user32 [0.4.10][SHELL32][USER32] Improve MSVC2010SP1 bootcd icon rendering CORE-14982 and CORE-15150 2022-12-04 21:27:39 +01:00
winsrv [0.4.10][NTOS][USERSRV] Silence noisy debug output. 2020-12-21 08:51:34 +01:00