Joachim Henze 232c45fcd7 [WIN32SS][COMCTL32] Commit Flip_Fix_9.patch ... flip_fix_9.patch fixes: CORE-16984 " 'SPINA Thrulg' / 'SPINA Thyr' / 'Sim Thyr' have images flipped" CORE-17194 "StretchDIBits test" isn't work correctly" "Output of 'Project 3 Test'" CORE-14701 "DVDStyler 3.0.4 transparent toolbars" CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg" CORE-14671 "'Peazip' shows icons in buttons and menubar vertically flipped" "Double Commander shoes icons flipped in buttons, menubar, listview and the treeview" CORE-13273 "Welcome to Lazarus" icon shows flipped CORE-13026 "'CudaText app' icon shows flipped" Not all of those are duplicates, although they appear to be at first glance. It affects different controls and some of those tickets do have different 'guilty revs' than others. The patch does consist of 3 parts: 1.) win32ss/gdi/ntgdi/dibobj.c This one is the most clean part of it, that addresses most of the flipping issues now. 2.) The hack in comctl32.h redefining the version: We used that in the past to appease some, but not all of the issues listed above. But it does hide additional issues, e.g. in DvDStyler, therefore we seem to still need that appeasement even today. Most likely it would make sense to aim to avoid this part in the future. part 2.) was committed as first appeasement on its own already into 0.4.14-RC-24-g 198b61e 0.4.13-RC-7-g 67211fa 0.4.12-RC-5-g 8449527 0.4.11-RC-16-g b906163 0.4.10-RC-7-g f1e80fe 0.4.9-RC-34-g 9d758ae 3.) toolbar.c change That part fixes at least the toolbar case for DvDStyler without relying on the comctl32.h hack any longer, but it was still not enough to completely get rid of part 2.) yet. Many thanks to all contributors: 'I_kill_Bugs', Doug Lyons and also 'Julenuri' for testing. The patch gave nice testbot results: KVM: https://reactos.org/testman/compare.php?ids=75704,75714 VBox: https://reactos.org/testman/compare.php?ids=75705,75715 and we also created a summary of manual test-results: https://jira.reactos.org/browse/CORE-17415?focusedCommentId=126668&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-126668 If you read this comment via git blame and your goal is to get rid of the hack in comctl32.h, I would highly recommend to redo the tests of that testing table, and if that is asked too much, then please test at least the following cases: CORE-14701 "DVDStyler 3.0.4 transparent toolbars" CORE-14701 "DVDStyler 3.0.4 erroneously black around icons of welcome-dlg" "DVDStyler 3.0.4 erroneously black/transparent within comboboxes of properties of VMGM menu" and try to add what might be needed to fix them, and double-check again: "DoubleCommander optionsDlg the most complex testcase, contains flip-prone icons in treeview, listview, menubar, buttons, statics". Only some of its flipped icons were impacted by the comctl32.h change before.		2021-01-05 20:30:40 +01:00
..
dib	[WIN32SS][GDI] Assume pso->sizlBitmap.cy positiveness (#1743)	2019-07-21 21:39:05 +09:00
diblib	Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.	2017-10-03 07:45:34 +00:00
eng	[REACTOS] Cleanup INIT and some PAGE section allocations	2020-11-02 21:45:31 +03:00
gdi32	[CMAKE] Turn import libs into regular C static libs	2020-12-28 12:13:30 +01:00
ntgdi	[WIN32SS][COMCTL32] Commit Flip_Fix_9.patch	2021-01-05 20:30:40 +01:00