reactos/dll/win32/advapi32
Joachim Henze d23c219409 [0.4.7][ADVAPI32] Fix crash when running advapi32:security with DPH CORE-14719
Import the following Wine commits:
* 79636bebbfa Michael Müller: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
* 1d03ba76116 Hans Leidekker: advapi32: Fix parsing empty DACL/SACL security descriptor strings.
* 5bc2e83c7ab Hans Leidekker: advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.

It crashed randomly only without DPH, but was crashing reliably with system-wide-DPH.

The bug in advapi32.dll was unhidden by the upgraded test in 0.4.9-dev-555-g 3c1b7834e1
but the bug did also affect older versions of advapi32.dll. Was just not triggered then.
So that rev is not really "guilty". And that is also the reason why I do port it back further than
releases/0.4.9, because *when using the upgraded test* I could make it crash also on
0.4.8-release-113-g5daae85 and 0.4.7-release-128-ga203b7a with system-wide-DPH-enabled.
And the fix is effective in solving the issue also there.

The fix was picked from
0.4.10-dev-219-g 95c3e17a80
---------------
and since I do touch this module anyway, I decided to pick also the small improvements from
0.4.8-dev-272-g 7ed4c1dd03 which had no JIRA-ticket.
2022-03-04 10:59:16 +01:00
..
misc
reg
sec
service
token
wine
advapi32.h
advapi32.rc
advapi32.spec
CMakeLists.txt