reactos/dll
Timo Kreuzer c5158963a3 [ADVAPI32] Fix a buffer overflow in RegQueryValueExA
The code was trying to check whether the output string was already NULL terminated by RtlUnicodeToMultiByteN before NULL terminating it by checking DataStr[*count - 1] for a NULL terminator. But since RtlUnicodeToMultiByteSize always returns the size without the NULL terminator, DataStr[*count - 1] would always be the last actual character, never an optional NULL terminator.
For 0 sized strings this would actually lead to accessing the output buffer at position -1 (on 32 bit)  or 0xFFFFFFFF (on 64 bit).
Fix this by removing the check. This fixes a crash in advapi32_winetest:registry on x64.
2023-01-04 10:32:28 +01:00
..
3rdparty [LIBPNG] Update to version 1.6.39. CORE-18670 2022-11-27 10:10:53 -05:00
apisets
appcompat [APPHELP] Stop shimeng being initialized multiple times 2022-10-26 20:19:31 +02:00
cpl [TIMEDATE] Limit the expanded combobox height by using CBS_NOINTEGRALHEIGHT CORE-18665 2022-12-26 16:26:51 +01:00
directx [DDRAW] Sync the fix for swap_interval from Wine (#4831) 2022-11-09 20:44:30 +03:00
keyboard [KEYBOARD] Fix problems in our keyboard layouts 2022-10-05 21:28:15 +03:00
nls
np
ntdll [SMDLL][SMLIB] Deprecate the legacy ROS-specific SMDLL and improve SM client functions. (#4821) 2022-11-08 17:40:53 +01:00
opengl [CMAKE] Elimitate the use of GCC and CLANG variables 2022-05-27 01:37:34 +03:00
shellext [NTOBJSHEX] Return early from GetInfoFromPidl when pcidl is null in LPCITEMIDLIST (#4946) 2022-12-31 16:53:02 +01:00
win32 [ADVAPI32] Fix a buffer overflow in RegQueryValueExA 2023-01-04 10:32:28 +01:00
CMakeLists.txt