mirror of
https://github.com/reactos/reactos.git
synced 2025-03-10 18:24:02 +00:00

- Implement DC_vSelectSurface, that dereferences the old SURFACE and references the new. Use it instead of doing it manually. - Select NULL surface when doing cleanup. - Go back to ASSERT in GDIOBJ_ShareUnlockObjByPtr. Should (hopefully) not be hit anymore. - Add additional functions for tracing shared locks in gdidbg.c. - Add debugprints when leaking objects on process cleanup. svn path=/trunk/; revision=40196
296 lines
7.8 KiB
C
296 lines
7.8 KiB
C
#ifdef GDI_DEBUG
|
|
|
|
#define KeRosDumpStackFrames(Frames, Count) KdSystemDebugControl(TAG('R', 'o', 's', 'D'), (PVOID)Frames, Count, NULL, 0, NULL, KernelMode)
|
|
NTSYSAPI ULONG APIENTRY RtlWalkFrameChain(OUT PVOID *Callers, IN ULONG Count, IN ULONG Flags);
|
|
|
|
static int leak_reported = 0;
|
|
#define GDI_STACK_LEVELS 12
|
|
static ULONG GDIHandleAllocator[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1];
|
|
static ULONG GDIHandleLocker[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1];
|
|
static ULONG GDIHandleShareLocker[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1];
|
|
static ULONG GDIHandleDeleter[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1];
|
|
struct DbgOpenGDIHandle
|
|
{
|
|
ULONG idx;
|
|
int count;
|
|
};
|
|
#define H 1024
|
|
static struct DbgOpenGDIHandle h[H];
|
|
|
|
void IntDumpHandleTable(PGDI_HANDLE_TABLE HandleTable)
|
|
{
|
|
int i, n = 0, j, k, J;
|
|
|
|
if (leak_reported)
|
|
{
|
|
DPRINT1("gdi handle abusers already reported!\n");
|
|
return;
|
|
}
|
|
|
|
leak_reported = 1;
|
|
DPRINT1("reporting gdi handle abusers:\n");
|
|
|
|
/* step through GDI handle table and find out who our culprit is... */
|
|
for (i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++)
|
|
{
|
|
for (j = 0; j < n; j++)
|
|
{
|
|
next:
|
|
J = h[j].idx;
|
|
for (k = 0; k < GDI_STACK_LEVELS; k++)
|
|
{
|
|
if (GDIHandleAllocator[i][k]
|
|
!= GDIHandleAllocator[J][k])
|
|
{
|
|
if (++j == n)
|
|
goto done;
|
|
else
|
|
goto next;
|
|
}
|
|
}
|
|
goto done;
|
|
}
|
|
done:
|
|
if (j < H)
|
|
{
|
|
if (j == n)
|
|
{
|
|
h[j].idx = i;
|
|
h[j].count = 1;
|
|
n = n + 1;
|
|
}
|
|
else
|
|
h[j].count++;
|
|
}
|
|
}
|
|
/* bubble sort time! weeeeee!! */
|
|
for (i = 0; i < n-1; i++)
|
|
{
|
|
if (h[i].count < h[i+1].count)
|
|
{
|
|
struct DbgOpenGDIHandle t;
|
|
t = h[i+1];
|
|
h[i+1] = h[i];
|
|
j = i;
|
|
while (j > 0 && h[j-1].count < t.count)
|
|
j--;
|
|
h[j] = t;
|
|
}
|
|
}
|
|
/* print the worst offenders... */
|
|
DbgPrint("Worst GDI Handle leak offenders (out of %i unique locations):\n", n);
|
|
for (i = 0; i < n && h[i].count > 1; i++)
|
|
{
|
|
/* Print out the allocation count */
|
|
DbgPrint(" %i allocs: ", h[i].count);
|
|
|
|
/* Dump the frames */
|
|
KeRosDumpStackFrames(GDIHandleAllocator[h[i].idx], GDI_STACK_LEVELS);
|
|
|
|
/* Print new line for better readability */
|
|
DbgPrint("\n");
|
|
}
|
|
if (i < n && h[i].count == 1)
|
|
DbgPrint("(list terminated - the remaining entries have 1 allocation only)\n");
|
|
}
|
|
|
|
ULONG
|
|
CaptureStackBackTace(PVOID* pFrames, ULONG nFramesToCapture)
|
|
{
|
|
ULONG nFrameCount;
|
|
|
|
memset(pFrames, 0x00, (nFramesToCapture + 1) * sizeof(PVOID));
|
|
|
|
nFrameCount = RtlCaptureStackBackTrace(1, nFramesToCapture, pFrames, NULL);
|
|
|
|
if (nFrameCount < nFramesToCapture)
|
|
{
|
|
nFrameCount += RtlWalkFrameChain(pFrames + nFrameCount, nFramesToCapture - nFrameCount, 1);
|
|
}
|
|
|
|
return nFrameCount;
|
|
}
|
|
|
|
BOOL
|
|
GdiDbgHTIntegrityCheck()
|
|
{
|
|
ULONG i, nDeleted = 0, nFree = 0, nUsed = 0;
|
|
PGDI_TABLE_ENTRY pEntry;
|
|
BOOL r = 1;
|
|
|
|
KeEnterCriticalRegion();
|
|
|
|
/* FIXME: check reserved entries */
|
|
|
|
/* Now go through the deleted objects */
|
|
i = GdiHandleTable->FirstFree;
|
|
if (i)
|
|
{
|
|
pEntry = &GdiHandleTable->Entries[i];
|
|
for (;;)
|
|
{
|
|
nDeleted++;
|
|
|
|
/* Check the entry */
|
|
if ((pEntry->Type & GDI_ENTRY_BASETYPE_MASK) != 0)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Deleted Entry has a type != 0\n");
|
|
}
|
|
if ((ULONG_PTR)pEntry->KernelData >= GDI_HANDLE_COUNT)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Deleted entries KernelPointer too big\n");
|
|
}
|
|
if (pEntry->UserData != NULL)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Deleted entry has UserData != 0\n");
|
|
}
|
|
if (pEntry->ProcessId != 0)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Deleted entry has ProcessId != 0\n");
|
|
}
|
|
|
|
i = (ULONG_PTR)pEntry->KernelData;
|
|
if (!i)
|
|
{
|
|
break;
|
|
}
|
|
pEntry = &GdiHandleTable->Entries[i];
|
|
}
|
|
}
|
|
|
|
for (i = GdiHandleTable->FirstUnused;
|
|
i < GDI_HANDLE_COUNT;
|
|
i++)
|
|
{
|
|
pEntry = &GdiHandleTable->Entries[i];
|
|
|
|
if ((pEntry->Type) != 0)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Free Entry has a type != 0\n");
|
|
}
|
|
if ((ULONG_PTR)pEntry->KernelData != 0)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Free entries KernelPointer != 0\n");
|
|
}
|
|
if (pEntry->UserData != NULL)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Free entry has UserData != 0\n");
|
|
}
|
|
if (pEntry->ProcessId != 0)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Free entry has ProcessId != 0\n");
|
|
}
|
|
nFree++;
|
|
}
|
|
|
|
for (i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++)
|
|
{
|
|
HGDIOBJ Handle;
|
|
ULONG Type;
|
|
|
|
pEntry = &GdiHandleTable->Entries[i];
|
|
Type = pEntry->Type;
|
|
Handle = (HGDIOBJ)((Type << GDI_ENTRY_UPPER_SHIFT) + i);
|
|
|
|
if (Type & GDI_ENTRY_BASETYPE_MASK)
|
|
{
|
|
if (pEntry->KernelData == NULL)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Used entry has KernelData == 0\n");
|
|
}
|
|
if (pEntry->KernelData <= MmHighestUserAddress)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Used entry invalid KernelData\n");
|
|
}
|
|
if (((POBJ)(pEntry->KernelData))->hHmgr != Handle)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Used entry %ld, has invalid hHmg %p (expected: %p)\n",
|
|
i, ((POBJ)(pEntry->KernelData))->hHmgr, Handle);
|
|
}
|
|
nUsed++;
|
|
}
|
|
}
|
|
|
|
if (RESERVE_ENTRIES_COUNT + nDeleted + nFree + nUsed != GDI_HANDLE_COUNT)
|
|
{
|
|
r = 0;
|
|
DPRINT1("Number of all entries incorrect: RESERVE_ENTRIES_COUNT = %ld, nDeleted = %ld, nFree = %ld, nUsed = %ld\n",
|
|
RESERVE_ENTRIES_COUNT, nDeleted, nFree, nUsed);
|
|
}
|
|
|
|
KeLeaveCriticalRegion();
|
|
|
|
return r;
|
|
}
|
|
|
|
#define GDIDBG_TRACECALLER() \
|
|
DPRINT1("-> called from:\n"); \
|
|
KeRosDumpStackFrames(NULL, 20);
|
|
#define GDIDBG_TRACEALLOCATOR(handle) \
|
|
DPRINT1("-> allocated from:\n"); \
|
|
KeRosDumpStackFrames(GDIHandleAllocator[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_TRACELOCKER(handle) \
|
|
DPRINT1("-> locked from:\n"); \
|
|
KeRosDumpStackFrames(GDIHandleLocker[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_TRACESHARELOCKER(handle) \
|
|
DPRINT1("-> locked from:\n"); \
|
|
KeRosDumpStackFrames(GDIHandleShareLocker[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_TRACEDELETER(handle) \
|
|
DPRINT1("-> deleted from:\n"); \
|
|
KeRosDumpStackFrames(GDIHandleDeleter[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_CAPTUREALLOCATOR(handle) \
|
|
CaptureStackBackTace((PVOID*)GDIHandleAllocator[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_CAPTURELOCKER(handle) \
|
|
CaptureStackBackTace((PVOID*)GDIHandleLocker[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_CAPTURESHARELOCKER(handle) \
|
|
CaptureStackBackTace((PVOID*)GDIHandleShareLocker[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_CAPTUREDELETER(handle) \
|
|
CaptureStackBackTace((PVOID*)GDIHandleDeleter[GDI_HANDLE_GET_INDEX(handle)], GDI_STACK_LEVELS);
|
|
#define GDIDBG_DUMPHANDLETABLE() \
|
|
IntDumpHandleTable(GdiHandleTable)
|
|
#define GDIDBG_INITLOOPTRACE() \
|
|
ULONG Attempts = 0;
|
|
#define GDIDBG_TRACELOOP(Handle, PrevThread, Thread) \
|
|
if ((++Attempts % 20) == 0) \
|
|
{ \
|
|
DPRINT1("[%d] Handle 0x%p Locked by 0x%x (we're 0x%x)\n", Attempts, Handle, PrevThread, Thread); \
|
|
}
|
|
|
|
ULONG
|
|
FASTCALL
|
|
GDIOBJ_IncrementShareCount(POBJ Object)
|
|
{
|
|
INT cLocks = InterlockedIncrement((PLONG)&Object->ulShareCount);
|
|
GDIDBG_CAPTURESHARELOCKER(Object->hHmgr);
|
|
ASSERT(cLocks >= 1);
|
|
return cLocks;
|
|
}
|
|
|
|
#else
|
|
|
|
#define GDIDBG_TRACECALLER()
|
|
#define GDIDBG_TRACEALLOCATOR(index)
|
|
#define GDIDBG_TRACELOCKER(index)
|
|
#define GDIDBG_TRACESHARELOCKER(index)
|
|
#define GDIDBG_CAPTUREALLOCATOR(index)
|
|
#define GDIDBG_CAPTURELOCKER(index)
|
|
#define GDIDBG_CAPTURESHARELOCKER(index)
|
|
#define GDIDBG_CAPTUREDELETER(handle)
|
|
#define GDIDBG_DUMPHANDLETABLE()
|
|
#define GDIDBG_INITLOOPTRACE()
|
|
#define GDIDBG_TRACELOOP(Handle, PrevThread, Thread)
|
|
#define GDIDBG_TRACEDELETER(handle)
|
|
|
|
#endif /* GDI_DEBUG */
|
|
|