reactos/modules/rostests/apitests/shell32/ShellExecuteEx.cpp
Katayama Hirofumi MZ ab4c0d6afd
[SHELL32_APITEST] Make ShellExecuteEx testcase stable (#6617)
Making the tests trustworthy.
JIRA issue: ROSTESTS-389
- Enable command line checking.
- Rewrite the tests for better tests.
- Remove dependency with shell32_apitest_sub.
- Close the newly opened windows by Alt+F4 at ending.
2024-03-13 17:09:20 +09:00

500 lines
17 KiB
C++

/*
* PROJECT: ReactOS api tests
* LICENSE: GPLv2+ - See COPYING in the top level directory
* PURPOSE: Testing ShellExecuteEx
* PROGRAMMER: Yaroslav Veremenko <yaroslav@veremenko.info>
* Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
*/
#include "shelltest.h"
#include <pstypes.h>
#include <psfuncs.h>
#include <stdlib.h>
#include <stdio.h>
#include <strsafe.h>
#include <versionhelpers.h>
static WCHAR s_win_dir[MAX_PATH];
static WCHAR s_sys_dir[MAX_PATH];
static WCHAR s_win_notepad[MAX_PATH];
static WCHAR s_sys_notepad[MAX_PATH];
static WCHAR s_win_test_exe[MAX_PATH];
static WCHAR s_sys_test_exe[MAX_PATH];
static WCHAR s_win_bat_file[MAX_PATH];
static WCHAR s_sys_bat_file[MAX_PATH];
static WCHAR s_win_txt_file[MAX_PATH];
static WCHAR s_sys_txt_file[MAX_PATH];
static WCHAR s_win_notepad_cmdline[MAX_PATH];
static WCHAR s_sys_notepad_cmdline[MAX_PATH];
static WCHAR s_win_test_exe_cmdline[MAX_PATH];
static WCHAR s_sys_test_exe_cmdline[MAX_PATH];
static BOOL s_bWow64;
#define REG_APPPATHS L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"
typedef enum TEST_RESULT
{
TEST_FAILED,
TEST_SUCCESS_NO_PROCESS,
TEST_SUCCESS_WITH_PROCESS,
} TEST_RESULT;
typedef struct TEST_ENTRY
{
INT line;
TEST_RESULT result;
LPCWSTR lpFile;
LPCWSTR cmdline;
} TEST_ENTRY, *PTEST_ENTRY;
static void
TEST_DoTestEntry(INT line, TEST_RESULT result, LPCWSTR lpFile, LPCWSTR cmdline = NULL);
static void TEST_DoTestEntries(void)
{
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, NULL);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"");
TEST_DoTestEntry(__LINE__, TEST_FAILED, L"This is an invalid path.");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_sys_bat_file, NULL);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_sys_test_exe, s_sys_test_exe_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_sys_txt_file, NULL);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_win_bat_file, NULL);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_win_notepad, s_win_notepad_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_win_test_exe, s_win_test_exe_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, s_win_txt_file, NULL);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"notepad", s_sys_notepad_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"notepad.exe", s_sys_notepad_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"\"notepad.exe\"", s_sys_notepad_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"\"notepad\"", s_sys_notepad_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"test program.exe", s_sys_test_exe_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"\"test program.exe\"", s_sys_test_exe_cmdline);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, s_win_dir);
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, s_sys_dir);
TEST_DoTestEntry(__LINE__, TEST_FAILED, L"shell:ThisIsAnInvalidName");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"::{20D04FE0-3AEA-1069-A2D8-08002B30309D}"); // My Computer
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}"); // My Computer (with shell:)
if (!IsWindowsVistaOrGreater())
{
WCHAR szCurDir[MAX_PATH];
GetCurrentDirectoryW(_countof(szCurDir), szCurDir);
SetCurrentDirectoryW(s_sys_dir);
TEST_DoTestEntry(__LINE__, TEST_FAILED, L"::{21EC2020-3AEA-1069-A2DD-08002B30309D}"); // Control Panel (without path)
SetCurrentDirectoryW(szCurDir);
}
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{21EC2020-3AEA-1069-A2DD-08002B30309D}"); // Control Panel (with path)
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{21EC2020-3AEA-1069-A2DD-08002B30309D}"); // Control Panel (with path and shell:)
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:AppData");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Common Desktop");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Common Programs");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Common Start Menu");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Common StartUp");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:ControlPanelFolder");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Desktop");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Favorites");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Fonts");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Local AppData");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:My Pictures");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Personal");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Programs");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Recent");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:RecycleBinFolder");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:SendTo");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:Start Menu");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_NO_PROCESS, L"shell:StartUp");
}
static LPWSTR
getCommandLineFromProcess(HANDLE hProcess)
{
PEB peb;
PROCESS_BASIC_INFORMATION info;
RTL_USER_PROCESS_PARAMETERS Params;
NtQueryInformationProcess(hProcess, ProcessBasicInformation, &info, sizeof(info), NULL);
ReadProcessMemory(hProcess, info.PebBaseAddress, &peb, sizeof(peb), NULL);
ReadProcessMemory(hProcess, peb.ProcessParameters, &Params, sizeof(Params), NULL);
LPWSTR cmdline = Params.CommandLine.Buffer;
SIZE_T cchCmdLine = Params.CommandLine.Length;
LPWSTR pszBuffer = (LPWSTR)calloc(cchCmdLine + 1, sizeof(WCHAR));
ReadProcessMemory(hProcess, cmdline, pszBuffer, cchCmdLine, NULL);
pszBuffer[cchCmdLine] = UNICODE_NULL;
return pszBuffer; // needs free()
}
static void TEST_DoTestEntryStruct(const TEST_ENTRY *pEntry)
{
SHELLEXECUTEINFOW info = { sizeof(info) };
info.fMask = SEE_MASK_NOCLOSEPROCESS | SEE_MASK_WAITFORINPUTIDLE | SEE_MASK_FLAG_NO_UI;
info.hwnd = NULL;
info.lpVerb = NULL;
info.lpFile = pEntry->lpFile;
info.nShow = SW_SHOWNORMAL;
BOOL ret = ShellExecuteExW(&info);
TEST_RESULT result;
if (ret && info.hProcess)
result = TEST_SUCCESS_WITH_PROCESS;
else if (ret && !info.hProcess)
result = TEST_SUCCESS_NO_PROCESS;
else
result = TEST_FAILED;
ok(pEntry->result == result,
"Line %d: result: %d vs %d\n", pEntry->line, pEntry->result, result);
if (pEntry->result == TEST_SUCCESS_WITH_PROCESS && pEntry->cmdline && !s_bWow64)
{
LPWSTR cmdline = getCommandLineFromProcess(info.hProcess);
if (!cmdline)
{
skip("!cmdline\n");
}
else
{
ok(lstrcmpiW(pEntry->cmdline, cmdline) == 0,
"Line %d: cmdline: '%ls' vs '%ls'\n", pEntry->line,
pEntry->cmdline, cmdline);
}
TerminateProcess(info.hProcess, 0xDEADFACE);
free(cmdline);
}
CloseHandle(info.hProcess);
}
static void
TEST_DoTestEntry(INT line, TEST_RESULT result, LPCWSTR lpFile, LPCWSTR cmdline)
{
TEST_ENTRY entry = { line, result, lpFile, cmdline };
TEST_DoTestEntryStruct(&entry);
}
static BOOL
enableTokenPrivilege(LPCWSTR pszPrivilege)
{
HANDLE hToken;
if (!OpenProcessToken(GetCurrentProcess(), TOKEN_ADJUST_PRIVILEGES | TOKEN_QUERY, &hToken))
return FALSE;
TOKEN_PRIVILEGES tkp = { 0 };
if (!LookupPrivilegeValueW(NULL, pszPrivilege, &tkp.Privileges[0].Luid))
return FALSE;
tkp.PrivilegeCount = 1;
tkp.Privileges[0].Attributes = SE_PRIVILEGE_ENABLED;
return AdjustTokenPrivileges(hToken, FALSE, &tkp, 0, NULL, NULL);
}
typedef struct WINDOW_LIST
{
SIZE_T m_chWnds;
HWND *m_phWnds;
} WINDOW_LIST, *PWINDOW_LIST;
static BOOL CALLBACK EnumWindowsProc(HWND hwnd, LPARAM lParam)
{
if (!IsWindowVisible(hwnd))
return TRUE;
PWINDOW_LIST pList = (PWINDOW_LIST)lParam;
SIZE_T cb = (pList->m_chWnds + 1) * sizeof(HWND);
HWND *phWnds = (HWND *)realloc(pList->m_phWnds, cb);
if (!phWnds)
return FALSE;
phWnds[pList->m_chWnds++] = hwnd;
pList->m_phWnds = phWnds;
return TRUE;
}
static inline void TEST_GetWindowList(PWINDOW_LIST pList)
{
EnumWindows(EnumWindowsProc, (LPARAM)pList);
}
static void TEST_CloseNewWindows(PWINDOW_LIST List1, PWINDOW_LIST List2)
{
for (SIZE_T i2 = 0; i2 < List2->m_chWnds; ++i2)
{
BOOL bFoundInList1 = FALSE;
HWND hWnd = List2->m_phWnds[i2];
for (SIZE_T i1 = 0; i1 < List1->m_chWnds; ++i1)
{
if (hWnd == List1->m_phWnds[i1])
{
bFoundInList1 = TRUE;
goto Escape;
}
}
Escape:
if (!bFoundInList1)
{
for (INT i = 0; i < 5; ++i)
{
if (!IsWindow(hWnd))
break;
SwitchToThisWindow(hWnd, TRUE);
// Alt+F4
keybd_event(VK_MENU, 0x38, 0, 0);
keybd_event(VK_F4, 0x3E, 0, 0);
keybd_event(VK_F4, 0x3E, KEYEVENTF_KEYUP, 0);
keybd_event(VK_MENU, 0x38, KEYEVENTF_KEYUP, 0);
Sleep(100);
}
}
}
}
static WINDOW_LIST s_List1, s_List2;
static BOOL TEST_Start(void)
{
// Check Wow64
s_bWow64 = FALSE;
IsWow64Process(GetCurrentProcess(), &s_bWow64);
if (s_bWow64)
skip("Wow64: Command Line check is skipped\n");
// getCommandLineFromProcess needs this
enableTokenPrivilege(SE_DEBUG_NAME);
// s_win_dir
GetWindowsDirectoryW(s_win_dir, _countof(s_win_dir));
// s_sys_dir
GetSystemDirectoryW(s_sys_dir, _countof(s_sys_dir));
// s_win_notepad
GetWindowsDirectoryW(s_win_notepad, _countof(s_win_notepad));
PathAppendW(s_win_notepad, L"notepad.exe");
// s_sys_notepad
GetSystemDirectoryW(s_sys_notepad, _countof(s_sys_notepad));
PathAppendW(s_sys_notepad, L"notepad.exe");
// s_win_test_exe
GetWindowsDirectoryW(s_win_test_exe, _countof(s_win_test_exe));
PathAppendW(s_win_test_exe, L"test program.exe");
BOOL ret = CopyFileW(s_win_notepad, s_win_test_exe, FALSE);
if (!ret)
{
skip("Please retry with admin rights\n");
return FALSE;
}
// s_sys_test_exe
GetSystemDirectoryW(s_sys_test_exe, _countof(s_sys_test_exe));
PathAppendW(s_sys_test_exe, L"test program.exe");
ok_int(CopyFileW(s_win_notepad, s_sys_test_exe, FALSE), TRUE);
// s_win_bat_file
GetWindowsDirectoryW(s_win_bat_file, _countof(s_win_bat_file));
PathAppendW(s_win_bat_file, L"test program.bat");
FILE *fp = _wfopen(s_win_bat_file, L"wb");
fprintf(fp, "exit /b 3");
fclose(fp);
ok_int(PathFileExistsW(s_win_bat_file), TRUE);
// s_sys_bat_file
GetSystemDirectoryW(s_sys_bat_file, _countof(s_sys_bat_file));
PathAppendW(s_sys_bat_file, L"test program.bat");
fp = _wfopen(s_sys_bat_file, L"wb");
fprintf(fp, "exit /b 4");
fclose(fp);
ok_int(PathFileExistsW(s_sys_bat_file), TRUE);
// s_win_txt_file
GetWindowsDirectoryW(s_win_txt_file, _countof(s_win_txt_file));
PathAppendW(s_win_txt_file, L"test_file.txt");
fp = _wfopen(s_win_txt_file, L"wb");
fclose(fp);
ok_int(PathFileExistsW(s_win_txt_file), TRUE);
// s_sys_txt_file
GetSystemDirectoryW(s_sys_txt_file, _countof(s_sys_txt_file));
PathAppendW(s_sys_txt_file, L"test_file.txt");
fp = _wfopen(s_sys_txt_file, L"wb");
fclose(fp);
ok_int(PathFileExistsW(s_sys_txt_file), TRUE);
// Check .txt settings
WCHAR szPath[MAX_PATH];
FindExecutableW(s_sys_txt_file, NULL, szPath);
if (lstrcmpiW(PathFindFileNameW(szPath), L"notepad.exe") != 0)
{
skip("Please associate .txt with notepad.exe before tests\n");
return FALSE;
}
// command lines
StringCchPrintfW(s_win_notepad_cmdline, _countof(s_win_notepad_cmdline),
L"\"%s\" ", s_win_notepad);
StringCchPrintfW(s_sys_notepad_cmdline, _countof(s_sys_notepad_cmdline),
L"\"%s\" ", s_sys_notepad);
StringCchPrintfW(s_win_test_exe_cmdline, _countof(s_win_test_exe_cmdline),
L"\"%s\" ", s_win_test_exe);
StringCchPrintfW(s_sys_test_exe_cmdline, _countof(s_sys_test_exe_cmdline),
L"\"%s\" ", s_sys_test_exe);
TEST_GetWindowList(&s_List1);
return TRUE;
}
static void TEST_End(void)
{
Sleep(500);
TEST_GetWindowList(&s_List2);
TEST_CloseNewWindows(&s_List1, &s_List2);
free(s_List1.m_phWnds);
free(s_List2.m_phWnds);
DeleteFileW(s_win_test_exe);
DeleteFileW(s_sys_test_exe);
DeleteFileW(s_win_txt_file);
DeleteFileW(s_sys_txt_file);
DeleteFileW(s_win_bat_file);
DeleteFileW(s_sys_bat_file);
}
static void test_properties()
{
WCHAR Buffer[MAX_PATH * 4];
HRESULT hrCoInit = CoInitialize(NULL);
GetModuleFileNameW(NULL, Buffer, _countof(Buffer));
SHELLEXECUTEINFOW info = { sizeof(info) };
info.cbSize = sizeof(SHELLEXECUTEINFOW);
info.fMask = SEE_MASK_INVOKEIDLIST | SEE_MASK_FLAG_NO_UI;
info.lpVerb = L"properties";
info.lpFile = Buffer;
info.nShow = SW_SHOW;
BOOL bRet = ShellExecuteExW(&info);
ok(bRet, "Failed! (GetLastError(): %d)\n", (int)GetLastError());
ok_ptr(info.hInstApp, (HINSTANCE)42);
WCHAR* Extension = PathFindExtensionW(Buffer);
if (Extension)
{
// The inclusion of this depends on the file display settings!
*Extension = UNICODE_NULL;
}
// Now retry it with the extension cut off
bRet = ShellExecuteExW(&info);
ok(bRet, "Failed! (GetLastError(): %d)\n", (int)GetLastError());
ok_ptr(info.hInstApp, (HINSTANCE)42);
// Now retry it with complete garabage
info.lpFile = L"complete garbage, cannot run this!";
bRet = ShellExecuteExW(&info);
ok_int(bRet, 0);
ok_ptr(info.hInstApp, (HINSTANCE)2);
if (SUCCEEDED(hrCoInit))
CoUninitialize();
}
static void test_sei_lpIDList()
{
if (IsWindowsVistaOrGreater())
{
skip("Vista+\n");
return;
}
/* This tests ShellExecuteEx with lpIDList for explorer C:\ */
/* ITEMIDLIST for CLSID of 'My Computer' followed by PIDL for 'C:\' */
BYTE lpitemidlist[30] = { 0x14, 0, 0x1f, 0, 0xe0, 0x4f, 0xd0, 0x20, 0xea,
0x3a, 0x69, 0x10, 0xa2, 0xd8, 0x08, 0, 0x2b, 0x30, 0x30, 0x9d, // My Computer
0x8, 0, 0x23, 0x43, 0x3a, 0x5c, 0x5c, 0, 0, 0,}; // C:\\ + NUL-NUL ending
SHELLEXECUTEINFOW ShellExecInfo = { sizeof(ShellExecInfo) };
ShellExecInfo.fMask = SEE_MASK_IDLIST;
ShellExecInfo.hwnd = NULL;
ShellExecInfo.nShow = SW_SHOWNORMAL;
ShellExecInfo.lpIDList = lpitemidlist;
BOOL ret = ShellExecuteExW(&ShellExecInfo);
ok_int(ret, TRUE);
}
static BOOL
CreateAppPath(LPCWSTR pszName, LPCWSTR pszValue)
{
WCHAR szSubKey[MAX_PATH];
StringCchPrintfW(szSubKey, _countof(szSubKey), L"%s\\%s", REG_APPPATHS, pszName);
LSTATUS error;
HKEY hKey;
error = RegCreateKeyExW(HKEY_LOCAL_MACHINE, szSubKey, 0, NULL, 0, KEY_WRITE, NULL,
&hKey, NULL);
if (error != ERROR_SUCCESS)
trace("Could not create test key (%lu)\n", error);
DWORD cbValue = (lstrlenW(pszValue) + 1) * sizeof(WCHAR);
error = RegSetValueExW(hKey, NULL, 0, REG_SZ, (LPBYTE)pszValue, cbValue);
if (error != ERROR_SUCCESS)
trace("Could not set value of the test key (%lu)\n", error);
RegCloseKey(hKey);
return error == ERROR_SUCCESS;
}
static VOID
DeleteAppPath(LPCWSTR pszName)
{
WCHAR szSubKey[MAX_PATH];
StringCchPrintfW(szSubKey, _countof(szSubKey), L"%s\\%s", REG_APPPATHS, pszName);
LSTATUS error = RegDeleteKeyW(HKEY_LOCAL_MACHINE, szSubKey);
if (error != ERROR_SUCCESS)
trace("Could not remove the test key (%lu)\n", error);
}
static void TEST_AppPath(void)
{
if (CreateAppPath(L"app_path_test.bat", s_win_test_exe))
{
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"app_path_test.bat");
TEST_DoTestEntry(__LINE__, TEST_FAILED, L"app_path_test.bat.exe");
DeleteAppPath(L"app_path_test.bat");
}
if (CreateAppPath(L"app_path_test.bat.exe", s_sys_test_exe))
{
TEST_DoTestEntry(__LINE__, TEST_FAILED, L"app_path_test.bat");
TEST_DoTestEntry(__LINE__, TEST_SUCCESS_WITH_PROCESS, L"app_path_test.bat.exe");
DeleteAppPath(L"app_path_test.bat.exe");
}
}
START_TEST(ShellExecuteEx)
{
#ifdef _WIN64
skip("Win64 is not supported yet\n");
return;
#endif
if (!TEST_Start())
return;
TEST_AppPath();
TEST_DoTestEntries();
test_properties();
test_sei_lpIDList();
TEST_End();
}